Add API-33 to the nightly build #7552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
nightly33
branch
2 times, most recently
from
0943f00
to
308bb29
Compare
dellis1972
force-pushed
the
nightly33
branch
from
308bb29
to
5cbfa37
Compare
pjcollins
approved these changes
Nov 21, 2022
jonpryor
reviewed
Nov 21, 2022
| @@ -85,6 +85,9 @@ bool AddressesAreEqual (List <IPAddress> one, List <IPAddress> two) | |||
|
|
|||
| bool HardwareAddressesAreEqual (byte[] one, byte[] two) | |||
| { | |||
| // Under API 33 .Net doesn't return the hardware address. So we need to ignore it | |||
| if (Android.OS.Build.VERSION.SdkInt == Android.OS.BuildVersionCodes.Tiramisu) | |||
There was a problem hiding this comment.
@dellis1972: Shouldn't this use >= so that API-34 hits this codepath? Or do we want it to fail on future API-34?
There was a problem hiding this comment.
So we could. but i'd rather change that in API 34 if or when we hit that issue. This is only in a unit test not the actual System.Net code.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 22, 2022
* main: Bump to mono/mono@6dd9def5 (dotnet#7574) Bump to dotnet/installer@296eeb3 8.0.100-alpha.1.22570.9 (dotnet#7571) [ci] Add API-33 to the nightly build (dotnet#7552) [docs] Fix typo in XA0134 (dotnet#7569) [docs] how to `dotnet trace` our build (dotnet#7573) [Xamarin.Android.Build.Tasks] Useful errors when using binutils (dotnet#7566) Bump SQLite to 3.40.0 (dotnet#7564)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Nov 22, 2022
* main: Bump to mono/mono@6dd9def5 (dotnet#7574) Bump to dotnet/installer@296eeb3 8.0.100-alpha.1.22570.9 (dotnet#7571) [ci] Add API-33 to the nightly build (dotnet#7552) [docs] Fix typo in XA0134 (dotnet#7569) [docs] how to `dotnet trace` our build (dotnet#7573) [Xamarin.Android.Build.Tasks] Useful errors when using binutils (dotnet#7566) Bump SQLite to 3.40.0 (dotnet#7564)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7490
Lets ass API 33 to the nightly build tests. Note the
defaultimage is not available so we have to use thegoogle_apisimage instead.Also it seems that under API 33 dotnet is unable to get the hardware address of the network adapters. As a result the tests which compare these were failing. So for API 33 we ignore the hardware address check, but still continue to check other aspects of the network adapters.