Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nightly Tests for Humanizer #7627

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Dec 9, 2022

Tests #7622

Localisation assemblies were not being fast deployed. Commit https://github.com/xamarin/monodroid/commit/1f52d5873960cf72685b9b08dbe262fc1ad4ca13
fixed that. However we need to add a unit test to make sure that these files are deployed and
actually produce the required results.

So lets use Humanizer to handle the localisation. This PR adds a test which checks that the
app on the device outputs the expected text which Humanizer is supposed to generate.
It also updates existing packaging tests to make sure that the required satellite assemblies are
packaged.

@dellis1972 dellis1972 added the do-not-merge PR should not be merged. label Dec 9, 2022
@dellis1972
Copy link
Contributor Author

Will need #7925

@dellis1972 dellis1972 marked this pull request as ready for review April 4, 2023 12:34
@dellis1972 dellis1972 removed the do-not-merge PR should not be merged. label Apr 4, 2023
@dellis1972 dellis1972 merged commit a917ac8 into dotnet:main Apr 5, 2023
@dellis1972 dellis1972 deleted the Issue7622 branch April 5, 2023 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants