Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #7677

Merged
merged 11 commits into from
Jan 19, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 9, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 8.0.100-1.22612.2 to 8.0.100-1.23055.2 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 8.0.0-alpha.1.22605.1 to 8.0.0-alpha.1.23058.2 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100: from 8.0.0-alpha.1.22558.2 to 8.0.0-alpha.1.22620.1 (parent: Microsoft.NETCore.App.Ref)

From https://github.com/dotnet/installer

  • Subscription: 0ba14476-1d1a-452a-3b67-08da9690aef0
  • Build: 20230113.11
  • Date Produced: January 14, 2023 1:06:53 AM UTC
  • Commit: 9962c6a686a31ba1e7c20983a810ba7989c3fc0c
  • Branch: refs/heads/main

…230109.3

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-alpha.1.22622.3 -> To Version 8.0.100-alpha.1.23059.3

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100
 From Version 8.0.100-1.22612.2 -> To Version 8.0.100-1.23055.2 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers
Copy link
Member

Something seems majorly busted:

/Users/builder/azdo/_work/1/s/xamarin-android/bin/Release/dotnet/sdk/8.0.100-alpha.1.23059.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.Shared.targets(152,5):
error MSB4062: The "CheckForImplicitPackageReferenceOverrides" task could not be loaded from the assembly /Users/builder/azdo/_work/1/s/xamarin-android/bin/Release/dotnet/sdk/8.0.100-alpha.1.23059.3/Sdks/Microsoft.NET.Sdk/targets/../tools/net8.0/Microsoft.NET.Build.Tasks.dll.
Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
The system cannot find the file specified.

I'll try a newer build tomorrow, and file an issue if it isn't resolved.

…230110.5

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-alpha.1.22622.3 -> To Version 8.0.100-alpha.1.23060.5

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100
 From Version 8.0.100-1.22612.2 -> To Version 8.0.100-1.23055.2 (parent: Microsoft.Dotnet.Sdk.Internal
…230113.11

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-alpha.1.22622.3 -> To Version 8.0.100-alpha.1.23063.11

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100
 From Version 8.0.100-1.22612.2 -> To Version 8.0.100-1.23055.2 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers
Copy link
Member

@pjcollins is there any chance that ./bin/Release/dotnet would be leftover from a past build?

dotnet/sdk/8.0.100-alpha.1.23063.11/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.Shared.targets(152,5): error MSB4062: The "CheckForImplicitPackageReferenceOverrides" task could not be loaded from the assembly /Users/builder/azdo/_work/1/s/xamarin-android/bin/Release/dotnet/sdk/8.0.100-alpha.1.23063.11/Sdks/Microsoft.NET.Sdk/targets/../tools/net8.0/Microsoft.NET.Build.Tasks.dll. Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. 

I can't seem to reproduce on Windows or Mac?

@pjcollins
Copy link
Member

@pjcollins is there any chance that ./bin/Release/dotnet would be leftover from a past build?

The checkout step looks like it is doing a fresh init/clone so I don't think we would have any stale files in here.

It seems like this is happening when trying to build monodroid, I'll try to reproduce it.

@jonathanpeppers
Copy link
Member

Ok, maybe this is the wrong dotnet:

https://github.com/xamarin/monodroid/blob/0081a380c91528e4d9ef8a535806b8e7db9e5e53/monodroid.proj#L65-L76

Seems like something is confused and running .NET 7 instead of 8? Could these be <MSBuild/> calls instead?

@jonathanpeppers jonathanpeppers marked this pull request as draft January 17, 2023 21:44
@jonathanpeppers
Copy link
Member

Putting this in draft as I test monodroid fixes.

@jonathanpeppers jonathanpeppers marked this pull request as ready for review January 18, 2023 06:11
Avoids the build warning:

    warning NU1603: UnnamedProject depends on Microsoft.NET.ILLink.Tasks (>= 7.0.100-1.22579.2) but Microsoft.NET.ILLink.Tasks 7.0.100-1.22579.2 was not found. An approximate best match of Microsoft.NET.ILLink.Tasks 7.0.100-1.22579.3 was resolved.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One legacy test lane failed on provisionator, and the linux lane is timing.

Given the AzDO issues we are seeing right now, I think this is good enough to merge -- not going to requeue those.

@jonathanpeppers jonathanpeppers merged commit 164e799 into main Jan 19, 2023
@jonathanpeppers jonathanpeppers deleted the darc-main-55eebd0d-8fd0-4120-9dda-027eb2496793 branch January 19, 2023 22:51
grendello added a commit to grendello/xamarin-android that referenced this pull request Jan 26, 2023
* main: (32 commits)
  [monodroid] Replace `exit()` with `abort()` in native code (dotnet#7734)
  Bump to xamarin/Java.Interop/main@8a1ae57 (dotnet#7738)
  [build] bump `$(AndroidNet7Version)` (dotnet#7737)
  Bump to xamarin/Java.Interop/main@1366d99 (dotnet#7718)
  [Xamarin.Android.Build.Tasks] fix AndroidGenerateResourceDesigner (dotnet#7721)
  Bump to xamarin/monodroid@50faac94 (dotnet#7725)
  Revert "[Xamarin.Android.Build.Tasks] fix cases of missing `@(Reference)` (dotnet#7642)" (dotnet#7726)
  [marshal methods] Properly support arrays of arrays (dotnet#7707)
  Bump to dotnet/installer@9962c6a 8.0.100-alpha.1.23063.11 (dotnet#7677)
  [Actions] Add action to bump the hash used for the unified pipeline (dotnet#7712)
  Bump to xamarin/xamarin-android-tools/main@099fd95 (dotnet#7709)
  [ci] Move build stages into yaml templates (dotnet#7553)
  [Xamarin.Android.Build.Tasks] fix NRE in `<GenerateResourceCaseMap/>` (dotnet#7716)
  [ci] Pass token when building Designer tests (dotnet#7715)
  [Mono.Android] Android.Telecom.InCallService.SetAudioRoute() + enum (dotnet#7711)
  [Mono.Android] Fix some incorrect enums. (dotnet#7670)
  [Xamarin.Android.Build.Tasks] _Microsoft.Android.Resource.Designer namespace (dotnet#7681)
  LEGO: Merge pull request 7713
  [Xamarin.Android.Build.Tasks] lazily populate Resource lookup (dotnet#7686)
  [Xamarin.Android.Build.Tasks] skip XA1034 logic in some cases (dotnet#7680)
  ...
grendello added a commit to grendello/xamarin-android that referenced this pull request Jan 30, 2023
* main:
  [marshal methods] Properly support arrays of arrays (dotnet#7707)
  Bump to dotnet/installer@9962c6a 8.0.100-alpha.1.23063.11 (dotnet#7677)
  [Actions] Add action to bump the hash used for the unified pipeline (dotnet#7712)
  Bump to xamarin/xamarin-android-tools/main@099fd95 (dotnet#7709)
  [ci] Move build stages into yaml templates (dotnet#7553)
  [Xamarin.Android.Build.Tasks] fix NRE in `<GenerateResourceCaseMap/>` (dotnet#7716)
  [ci] Pass token when building Designer tests (dotnet#7715)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants