Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xamarin.Android.Build.Tasks] Updating NuGet packages does not update the app #7892

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[Xamarin.Android.Build.Tasks] Updating NuGet packages does not update the app #7892

merged 1 commit into from
Mar 21, 2023

Commits on Mar 20, 2023

  1. [Xamarin.Android.Build.Tasks] Updating NuGet packages does not update… 

    … the app

Fixes dotnet#7890

We found and issue where if you upgraded a NuGet Package it did not up
date the assemblies in the `$(IntermediateOutputPath)android\assets` folder.
We have a unit test which checks this particular scenario, but it was
disabled on .net during the port to .net 6. We never got back to enable it.

The issue it turns out is that NuGet not longer populates the `ProjectLockFile`
property. As a result we never stored the `_NuGetAssetsTimestamp` in the
`build.props` file. This causes the `_CleanIntermediateIfNeeded` target
to be skipped when it really should run.

Switching over to using the `ProjectAssetsFile` property to populate the
`_NuGetAssetsTimestamp` property fixes the issue. Also the unit test was
updated to work on both Legacy and .net.
    @dellis1972
    dellis1972 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    e6bc2aa View commit details
    Browse the repository at this point in the history