[Mono.Android] Remove monoandroid10 target framework.
#8035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
jpobst
requested review from
pjcollins and
jonpryor
and removed request for
jonpryor,
dellis1972 and
jonathanpeppers
pjcollins
reviewed
May 12, 2023
| @@ -4,70 +4,33 @@ | |||
| <Import Project="..\..\Configuration.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>monoandroid10;$(DotNetTargetFramework)</TargetFrameworks> | |||
| <TargetFrameworks>$(DotNetTargetFramework)</TargetFrameworks> | |||
There was a problem hiding this comment.
I think we may be able to skip some extra outer/inner build processing by changing this to TargetFramework now, though I'm not sure if it makes much of a difference.
There was a problem hiding this comment.
I like this suggestion, and it probably applies to a lot of projects. I'll include this in some future cleanups. 👍
pjcollins
approved these changes
May 12, 2023
jonathanpeppers
approved these changes
May 12, 2023
dellis1972
approved these changes
May 15, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
May 16, 2023
* main: Bump to xamarin/xamarin-android-tools/main@3b8c467 (dotnet#8039) [Xamarin.Android.Build.Tasks] skip `proguard.txt` files in !app (dotnet#8025) [Mono.Android] Remove `monoandroid10` target framework (dotnet#8035)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
monoandroid10target framework fromMono.Android.csprojandMono.Android.Export.csproj.This enables removing
net472from Java.Interop: dotnet/java-interop#1099.