Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AndroidDependenciesTests] Use platform-tools 34.0.3 #8062

Merged
merged 1 commit into from
May 25, 2023

Conversation

pjcollins
Copy link
Member

The InstallAndroidDependenciesTest has been failing:

Failed InstallAndroidDependenciesTest [1 m 39 s]
  Error Message:
   Multiple failures or warnings in test:
  1) _AndroidSdkDirectory not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`, *probably* because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>3</micro>; expected 34.0.1!
  2)   _AndroidSdkDirectory was not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`.
  Expected: True
  But was:  False

Attempt to fix this by bumping the platform-tools version that we try to install during this test to 34.0.3.

The `InstallAndroidDependenciesTest` has been failing:

    Failed InstallAndroidDependenciesTest [1 m 39 s]
      Error Message:
       Multiple failures or warnings in test:
      1) _AndroidSdkDirectory not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`, *probably* because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>3</micro>; expected 34.0.1!
      2)   _AndroidSdkDirectory was not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`.
      Expected: True
      But was:  False

Attempt to fix this by bumping the platform-tools version that we try
to install during this test to 34.0.3.
@pjcollins pjcollins marked this pull request as ready for review May 25, 2023 00:00
@dellis1972 dellis1972 merged commit 3260c97 into dotnet:main May 25, 2023
jonpryor pushed a commit that referenced this pull request May 25, 2023
The `InstallAndroidDependenciesTest` has been failing:

    Failed InstallAndroidDependenciesTest [1 m 39 s]
      Error Message:
       Multiple failures or warnings in test:
      1) _AndroidSdkDirectory not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`, *probably* because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>3</micro>; expected 34.0.1!
      2)   _AndroidSdkDirectory was not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`.
      Expected: True
      But was:  False

Attempt to fix this by bumping the platform-tools version that we try
to install during this test to 34.0.3.
jonathanpeppers pushed a commit that referenced this pull request May 25, 2023
The `InstallAndroidDependenciesTest` has been failing:

    Failed InstallAndroidDependenciesTest [1 m 39 s]
      Error Message:
       Multiple failures or warnings in test:
      1) _AndroidSdkDirectory not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`, *probably* because Google's repository has a newer platform-tools package!  repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>3</micro>; expected 34.0.1!
      2)   _AndroidSdkDirectory was not set to new SDK path `/Users/runner/work/1/a/TestDebug/05-24_20.34.58/temp/InstallAndroidDependenciesTest/android-sdk`.
      Expected: True
      But was:  False

Attempt to fix this by bumping the platform-tools version that we try
to install during this test to 34.0.3.
grendello added a commit to grendello/xamarin-android that referenced this pull request May 26, 2023
* main:
  [Xamarin.Android.Build.Tasks] introduce Eol.targets for .NET 6 (dotnet#8047)
  [Xamarin.Android.Build.Tasks] Add $(_BindingsToolsLocation) to allow overriding binding tool binaries. (dotnet#8069)
  [tests] new test for provisioning JDKs (dotnet#8059)
  Localized file check-in by OneLocBuild Task (dotnet#8065)
  [AndroidDependenciesTests] Use platform-tools 34.0.3 (dotnet#8062)
  Bump to xamarin/Java.Interop/main@93c50fe (dotnet#8060)
  [Xamarin.Android.Build.Tasks] Update XA5300 text (dotnet#8057)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants