[Mono.Android] Bind java.time and java.time.chrono packages.
#8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
java-time
branch
3 times, most recently
from
c280a4c
to
5e1cde3
Compare
|
Commit message: Fixes: https://github.com/xamarin/xamarin-android/issues/8081
Context: 571546a1a6ad3015e573284313befd9a70bb7d96
When binding API-26 we chose not to bind the `java.time` and
`java.time.chrono` Android packages (571546a1), likely due to the
amount of metadata required to build them correctly.
(It also requires the use of `managedOverride`, which didn't exist
at the time.)
However, they are pretty useful packages, so let's invest the effort
to get them bound.
Additionally, this results in now producing bindings for many methods
in unrelated types that consume `java.time` types. |
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Aug 10, 2023
* main: [Mono.Android.dll] Fix [SupportedOSPlatform] warnings. (dotnet#8247) Bump to xamarin/monodroid@a5248591 (dotnet#8258) [Mono.Android] Bind `java.time` and `java.time.chrono` packages. (dotnet#8088) Bump to xamarin/Java.Interop/main@5adb4d4 (dotnet#8251) [ci] Use fewer agents for macOS MSBuild tests (dotnet#8257) [ci] Report when dotnet-test-slicer fails (dotnet#8259) [monodroid] Do not build host or classic runtimes (dotnet#8256)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8081
Originally we chose not to bind the
java.timeandjava.time.chronoAndroid packages, likely due to the amount of metadata required to build them correctly. (It also requires the use ofmanagedOverride, which didn't exist at the time.)However, they are pretty useful packages, so let's invest the effort to get them bound.
Additionally, this results in now producing bindings for many methods in unrelated types that consume
java.timetypes.