Use $(AndroidPackVersionLong) to get XA version #8124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Ok, I guess it uses a task to get the commit distance...
(_GetSubmodulesVersionInfo target) ->
/Users/builder/azdo/_work/1/s/xamarin-android/build-tools/scripts/XAVersionInfo.targets(25,5): error MSB4062: The "Xamarin.Android.BuildTools.PrepTasks.GitCommitInfo" task could not be loaded from the assembly /Users/builder/azdo/_work/1/s/xamarin-android/bin/BuildRelease/netstandard2.0/xa-prep-tasks.dll. Could not load file or assembly '/Users/builder/azdo/_work/1/s/xamarin-android/bin/BuildRelease/netstandard2.0/xa-prep-tasks.dll'. The system cannot find the file specified. [/Users/builder/azdo/_work/1/s/xamarin-android/build-tools/xaprepare/xaprepare/xaprepare.csproj]
/Users/builder/azdo/_work/1/s/xamarin-android/build-tools/scripts/XAVersionInfo.targets(25,5): error MSB4062: Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.
We could either try to move this task to xa-prep-tasks.csproj, or use these values instead?
These aren't quite as good, with the distance missing.
Contributor
Author
|
It built for me locally because I didn't build from a clean checkout, doh. Yeah, I think I'll switch to the properties in |
Xamarin.Android's native runtime logs a handful of version information on application startup. This information includes XA version, up until now represented by the `$(ProductVersion)` MSBuild property. However, the property hasn't been updated for quite a while, with Xamarin.Android having switched to `$(AndroidPackVersion)` instead. Modify xaprepare to use `$(AndroidPackVersion)` instead of `$(ProductVersion)` so that we log the correct version at application startup.
grendello
force-pushed
the
xaprepare-version
branch
from
98e953d to
5ef90a5
Compare
Contributor
|
Should this PR also remove |
* main: (102 commits) Bump to dotnet/installer@2809943e7a 8.0.100-rc.2.23431.5 (dotnet#8317) [build] Use Microsoft OpenJDK 17.0.8 (dotnet#8309) [Mono.Android] Add missing `[Flags]` attribute for generated enums. (dotnet#8310) Bump to dotnet/installer@c5e45fd659 8.0.100-rc.2.23427.4 (dotnet#8305) [xaprepare] Improve dotnet-install script logging (dotnet#8312) [xaprepare] Fix dotnet-install script size check (dotnet#8311) [Xamarin.Android.Build.Tasks] improve net6.0 "out of support" message (dotnet#8307) [monodroid] Fix the EnableNativeAnalyzers build (dotnet#8293) Bump to dotnet/installer@56d8c6497c 8.0.100-rc.2.23422.31 (dotnet#8291) [Xamarin.Android.Build.Tasks] Fix APT2264 error on Windows. (dotnet#8289) [Mono.Android] Marshal .NET stack trace to Throwable.getStackTrace() (dotnet#8185) [tests] Skip sign check when installing MAUI (dotnet#8288) Bump to xamarin/monodroid@057b17fe (dotnet#8286) [Xamarin.Android.Build.Tasks] add $(AndroidStripILAfterAOT) (dotnet#8172) Bump to dotnet/installer@ec2c1ec1b1 8.0.100-rc.2.23420.6 (dotnet#8281) Bump to dotnet/installer@001d8e4465 8.0.100-rc.2.23417.14 (dotnet#8276) [Mono.Android] [IntentFilter] pathSuffix & pathAdvancedPattern (dotnet#8261) $(AndroidPackVersionSuffix)=rc.2; net8 is 34.0.0-rc.2 (dotnet#8278) Bump to xamarin/xamarin-android-tools/main@52f0866 (dotnet#8241) [build] set file extension for common `ToolExe` values (dotnet#8267) ...
Contributor
Author
I guess it depends on whether code like the I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xamarin.Android's native runtime logs a handful of version information
on application startup. This information includes XA version, up until
now represented by the
$(ProductVersion)MSBuild property. However,the property hasn't been updated for quite a while, with Xamarin.Android
having switched to
$(AndroidPackVersion)instead.Modify xaprepare to use
$(AndroidPackVersion)instead of$(ProductVersion)so that we log the correct version at applicationstartup.