[Tests] Remove duplicates from XASdkTests #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've spent some time reviewing tests in `XASdkTests`, `BuildTest`, and `BuildTest2`. Tests from `XASdkTests` have been migrated to other fixtures or removed where applicable. * DotNetBuildXamarinForms has been removed and merged into CheckMonoComponentsMask. * DotNetIncremental has been removed and merged into BuildIncrementalAot. * DotNetDesignTimeBuild has been renamed to DesignTimeBuildSignAndroidPackage. * BenchmarkDotNet has been removed and merged into BuildHasNoWarnings. * BuildApplicationWithJavaSource has been removed due to existing coverage of .java file inclusion elsewhere. * BuildReleaseApplicationWithNugetPackages has been removed due to existing coverage in GenerateLibraryResourcesTests. * BuildAfterAddingNuget has been removed as the same scenario is covered in BuildAfterUpgradingNuget. * ValidateJavaVersion has been removed as .NET Android requires JDK 11+, which is not covered by any of the legacy parameters.
pjcollins
force-pushed
the
move-xasdktest
branch
from
c649870
to
b4ebfdd
Compare
jonathanpeppers
approved these changes
Aug 1, 2023
Yeah we are dropping some tests but shouldn't lose any coverage.
Unfortunately it's too hard to measure any execution time change in CI with the new fixtures and the splitting up of tests across 6 to 10 nodes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent some time reviewing tests in
XASdkTests,BuildTest, andBuildTest2. Tests fromXASdkTestshave been migrated to other fixtures or removed where applicable.DotNetBuildXamarinForms has been removed and merged into CheckMonoComponentsMask.
DotNetIncremental has been removed and merged into BuildIncrementalAot.
DotNetDesignTimeBuild has been renamed to DesignTimeBuildSignAndroidPackage.
BenchmarkDotNet has been removed and merged into BuildHasNoWarnings.
BuildApplicationWithJavaSource has been removed due to existing coverage of .java file inclusion elsewhere.
BuildReleaseApplicationWithNugetPackages has been removed due to existing coverage in GenerateLibraryResourcesTests.
BuildAfterAddingNuget has been removed as the same scenario is covered in BuildAfterUpgradingNuget.
ValidateJavaVersion has been removed as .NET Android requires JDK 11+, which is not covered by any of the legacy parameters.