[mono-runtimes, monodroid] Fix Mono runtime building, dependencies #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6bb1016 "broke" `build-tools/mono-runtimes`, in that it didn't build any Android target JIT ABIs, because it used the wrong MSBuild property for the condition checks -- it used `$(AndroidSupportedTargetJitAbis)`, not `$(AndroidSupportedTargetJitAbisForConditionalChecks)`. Doh! Fix that. Additionally, `src/monodroid` needs to depend upon `build-tools/mono-runtimes` because it depends upon eglib-config.h, which is generated as part of the mono build. `src/monodroid` doens't depend upon the generated `libmonosgen-2.0.so` file, but it *does* depend upon the build tree.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 30, 2020
Changes: dotnet/android-tools@12f52ac...f5fcb9f * dotnet/android-tools@f5fcb9f: [Xamarin.Android.Tools.AndroidSdk] Add support for cmdline-tools (dotnet#83) * dotnet/android-tools@f473ff9: [AndroidSdkWindows] Guard against exception checking registry (dotnet#79) * dotnet/android-tools@36d7fee: JetBrains OpenJDK 11 detection (dotnet#82)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
May 7, 2020
Changes: dotnet/android-tools@12f52ac...f5fcb9f * dotnet/android-tools@f5fcb9f: [Xamarin.Android.Tools.AndroidSdk] Add support for cmdline-tools (dotnet#83) * dotnet/android-tools@f473ff9: [AndroidSdkWindows] Guard against exception checking registry (dotnet#79) * dotnet/android-tools@36d7fee: JetBrains OpenJDK 11 detection (dotnet#82)
jonpryor
added a commit
that referenced
this pull request
May 7, 2020
Changes: dotnet/android-tools@12f52ac...f5fcb9f * dotnet/android-tools@f5fcb9f: [Xamarin.Android.Tools.AndroidSdk] Add support for cmdline-tools (#83) * dotnet/android-tools@f473ff9: [AndroidSdkWindows] Guard against exception checking registry (#79) * dotnet/android-tools@36d7fee: JetBrains OpenJDK 11 detection (#82)
jonpryor
added a commit
that referenced
this pull request
May 8, 2020
Changes: dotnet/android-tools@12f52ac...23c4fe0 * dotnet/android-tools@23c4fe0: [Xamarin.Android.Tools.AndroidSdk] Add support for cmdline-tools (#83) * dotnet/android-tools@cf9d325: [AndroidSdkWindows] Guard against exception checking registry (#79) * dotnet/android-tools@310c5cf: JetBrains OpenJDK 11 detection (#82)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6bb1016 "broke"
build-tools/mono-runtimes, in that it didn'tbuild any Android target JIT ABIs, because it used the wrong MSBuild
property for the condition checks -- it used
$(AndroidSupportedTargetJitAbis), not$(AndroidSupportedTargetJitAbisForConditionalChecks). Doh!Fix that.
Additionally,
src/monodroidneeds to depend uponbuild-tools/mono-runtimesbecause it depends upon eglib-config.h,which is generated as part of the mono build.
src/monodroiddoens'tdepend upon the generated
libmonosgen-2.0.sofile, but it doesdepend upon the build tree.