-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Stop building monodroid in builds from forks #8444
Conversation
de53fef
to
3078a28
Compare
Removes all usage of provisionator and monodroid build and test steps when building a PR from a fork.
Tagging everyone for review for awareness, once this lands any xamarin/monodroid related changes will need to come from xamarin-android branches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
One concern is: are we worried about accidentally merging a PR that was from a fork and thus has not had the full battery of checks run?
If we are, we could write a step that fails if running from a fork, so we would at least always see an error that we could choose to ignore if we want.
I will leave this decision up to others, as I do not use forks. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This looks good. What is the process for dealing with Third party contributions? they won't have the permissions to push to the main repo, so I guess we will need to merge PR's and then fix issues with the full build if they appear? |
Yeah this sounds about right, we will need to monitor our regular CI results a bit more closely to make sure it stays healthy after this. |
Should we perhaps change the default branch to |
The idea of adding an intermediate branch such as |
@pjcollins I'm more worried about timezones here - if someone in the US or Europe or anywhere else merges a broken 3rd party PR, then people waking up in the morning, while the committer isn't available, will be faced with a broken branch after they pull changes at the start of their day. We have (unfortunately) so few 3rd party PRs that the overhead shouldn't be too much. |
This PR still ran |
Removes all usage of provisionator and monodroid build and test steps when building a PR from a fork.
Removes all usage of provisionator and monodroid build and test steps
when building a PR from a fork.