-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Include ThirdPartyNotices in workload packs #8455
Conversation
Adds our `ThirdPartyNotices.txt` file to Microsoft.Android.Sdk.*.nupkg.
@jonpryor Looks like this works fine, do we want to include it in any other packs?
|
@pjcollins: should we call it % find ~/.nuget/packages/microsoft.* -iname THIRD-PARTY\*
$HOME/.nuget/packages/microsoft.aspnetcore.app.ref/7.0.9/THIRD-PARTY-NOTICES.TXT
…
$HOME/.nuget/packages/microsoft.netcore.app.host.osx-x64/7.0.9/THIRD-PARTY-NOTICES.TXT
…
# 689 total |
I think it should go into any workload pack that redistributes 3rd party code, which might very well be all of them? Certainly |
At a glance the Ref/Runtime packs only appear to contain our content, so I think the inclusion in the only the SDK packs should be sufficient. edit: On second thought, if we are mentioning build dependencies in there maybe it should go into all three pack types... |
Adds the
THIRD-PARTY-NOTICES.TXT
file to all packs that contain alicense file.