[build] Remove classic components from NUPKGs #8464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had already excluded most of the classic-specific and mono bundle components from our .NET NUPKGs, but we were still restributing a few files that should no longer be needed: * ICSharpCode.SharpZipLib.dll - dependency of mdoc.exe * Mono.Profiler.Log.dll - dependency of aprofutil.exe * Mono.CompilerServices.SymbolWriter.dll - dependency of pdb2mdb.exe * monodoc.dll - dependency of mdoc.exe The macOS signing targets have also been updated to sign and harden a handful of files that were being unintentionally skipped.
pjcollins
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
|
Testing a real signed build https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8599001&view=results |
jonathanpeppers
approved these changes
Oct 26, 2023
Comment on lines
-153
to
-154
| <_MSBuildFiles Include="$(MicrosoftAndroidSdkOutDir)Mono.Profiler.Log.dll" /> | ||
| <_MSBuildFiles Include="$(MicrosoftAndroidSdkOutDir)Mono.Profiler.Log.pdb" /> |
There was a problem hiding this comment.
I was checking this package, and it redistributes this file anyway:
I don't think it even had a way to find & load this assembly, so I had to put it inside this package.
|
Looks like |
[build] Remove classic components from .NET packages (#8464)
Context: 8ad7f520e7f7e01b77cc262e3577b93f7a5f52e7
Context: e0b472585e416e840926d1033b5bf1f43294175d
Context: fb637e082b07872bd8196eeb6f099c8536441620
Changes: https://github.com/xamarin/monodroid/compare/47bdaaa9b8ac16d6197a8982c8cc810d177c5cff...4d3ede83f699e1d127fed4a18de992819983d715
* xamarin/monodroid@4d3ede83f: [build] Add ICSharpCode.SharpZipLib.dll to dependencies (xamarin/monodroid#1384)
* xamarin/monodroid@461dc5a51: Bump external/android-sdk-installer from `f3906e6` to `4b2541e` (xamarin/monodroid#1383)
* xamarin/monodroid@e6c1728ce: Bump external/android-sdk-installer from `3880589` to `f3906e6` (xamarin/monodroid#1381)
* xamarin/monodroid@88c538ecc: Bump external/xamarin-android from `2b0761b` to `afd1274` (xamarin/monodroid#1380)
We had already excluded most of the Classic Xamarin.Android-specific
and mono bundle components from our .NET `.nupkg` files, but we were
still redistributing a few files that should no longer be needed:
* `Mono.Profiler.Log.dll`: dependency of `aprofutil.exe`, removed
from the .NET install in 8ad7f520.
* `Mono.CompilerServices.SymbolWriter.dll`: dependency of
`pdb2mdb.exe`, removed from the .NET install in e0b47258.
* `monodoc.dll`: dependency of `mdoc.exe`, removed from the .NET
install in fb637e08.
The macOS signing targets have also been updated to sign and harden a
handful of files that were being unintentionally skipped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had already excluded most of the classic-specific and mono bundle components from our .NET NUPKGs, but we were still restributing a few files that should no longer be needed: