[Xamarin.Android.Build.Tasks] Fix a bug when extracting resources. #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a small bug in the zip extraction. We were using `FileMode.OpenOrCreate` to write the files. The problem is `OpenOrCreate` does not truncate the file if it exists. So if we have a resource which is smaller than the file on disk we end up with additonal stuff at the end of it.. So lets use `Create` instead which will truncate the file if it exists aleady.
jonpryor
pushed a commit
that referenced
this pull request
Sep 13, 2017
) There is a small bug in the zip extraction. We were using `FileMode.OpenOrCreate` to write the files. The problem is `OpenOrCreate` does not truncate the file if it exists. So if we have a resource which is smaller than the file on disk we end up with additonal stuff at the end of it.. So lets use `Create` instead which will truncate the file if it exists aleady.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small bug in the zip extraction. We were using
FileMode.OpenOrCreateto write the files. The problem isOpenOrCreatedoes not truncate the file if it exists. Soif we have a resource which is smaller than the file on disk
we end up with additonal stuff at the end of it..
So lets use
Createinstead which will truncate the fileif it exists aleady.