Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono.Android] Replicate automated docs build #8498

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Nov 10, 2023

Updates mdoc to version 5.9.2.4, and updates the _RunMdoc target to
use the same commands and parameters as the automated docs build.

Updates mdoc to version 5.9.2.4, and updates the `_RunMdoc` target to
use the same commands and parameters as the [automated docs build][0].

[0]: https://apidrop.visualstudio.com/Content%20CI/_build?definitionId=5552
@pjcollins pjcollins marked this pull request as ready for review November 15, 2023 17:46
Comment on lines +246 to +247
<_Mdoc Condition=" '$(Pkgmdoc)' != '' ">"$(Pkgmdoc)/tools/net471/mdoc.exe"</_Mdoc>
<_Mdoc Condition=" '$(Pkgmdoc)' == '' ">"$(XAPackagesDir)/mdoc/$(MdocPackageVersion)/tools/net471/mdoc.exe"</_Mdoc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool runs on both Windows & Mac? Will we still require Mono to be installed on Mac?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we'll still have a dependency on mono for this, I was going to look at moving to a .NET version of mdoc once we deprecate the Xamarin.Android API docs.

@pjcollins pjcollins merged commit df08bb3 into main Nov 15, 2023
43 of 48 checks passed
@pjcollins pjcollins deleted the dev/pjc/doc-build-mirror branch November 15, 2023 23:29
grendello added a commit that referenced this pull request Nov 16, 2023
* main:
  [build] Remove NuGet.exe provisioning (#8506)
  [Mono.Android] Replicate automated docs build (#8498)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants