[tests] enable FixJavaAbstractMethod tests #8582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#7794 This ports the following projects to .NET 9 (for main): * `Xamarin.Android.FixJavaAbstractMethod-APIv1Binding.csproj` * `Xamarin.Android.FixJavaAbstractMethod-APIv2Binding.csproj` * `Xamarin.Android.FixJavaAbstractMethod-Library.csproj` Which allows us to enable `JavaAbstractMethodTest` in `Xamarin.Android.JcwGen-Tests/BindingTests.cs` One difference in the test appears to be System.Reflection, I am unable to retrieve an explicit interface method via: var mi = ic.GetType ().GetMethod ("MethodWithCursor"); Instead, I had to do: var mi = ic.GetType ().GetMethod ("global::Test.Bindings.ICursor.MethodWithCursor", BindingFlags.Instance | BindingFlags.NonPublic); This seems be a difference between Mono/Xamarin.Android and .NET 6+. Note this doesn't fully finish dotnet#7794 as there is still a test + more test projects to port.
jonathanpeppers
commented
Dec 12, 2023
tests/CodeGen-Binding/Xamarin.Android.JcwGen-Tests/BindingTests.cs
Outdated
Show resolved
Hide resolved
|
Looks like the test still works:
So don't see a need to rerun the lane that timed out, going to merge. |
grendello
added a commit
that referenced
this pull request
Dec 12, 2023
* main: [tests] enable FixJavaAbstractMethod tests (#8582) LEGO: Merge pull request 8587
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #7794
This ports the following projects to .NET 9 (for main):
Xamarin.Android.FixJavaAbstractMethod-APIv1Binding.csprojXamarin.Android.FixJavaAbstractMethod-APIv2Binding.csprojXamarin.Android.FixJavaAbstractMethod-Library.csprojWhich allows us to enable
JavaAbstractMethodTestinXamarin.Android.JcwGen-Tests/BindingTests.csOne difference in the test appears to be System.Reflection, I am unable to retrieve an explicit interface method via:
Instead, I had to do:
This seems be a difference between Mono/Xamarin.Android and .NET 6+.
Note this doesn't fully finish #7794 as there is still a test + more test projects to port.