Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] Add check for aapt2 invalid data path error #8640

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Jan 16, 2024

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1922983

Our error matching in Aapt2.cs did not include a new error message which has been introduced. As a result we got a APT2000 error instead of an actual error message which we get for other errors.
The error message in question is

 error: attribute ‘android:path’ in <data> tag has value of ‘code/fooauth://com.foo.foo, it must start with a leading slash ‘/’.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM. 👍

src/Xamarin.Android.Build.Tasks/Tasks/Aapt2.cs Outdated Show resolved Hide resolved
…rror.

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1922983

Our error matching in Aapt2.cs did not include a new error message which
has been introduced. As a result we got a APT2000 error instead of an
actual error message which we get for other errors.
@dellis1972 dellis1972 merged commit 705bb47 into dotnet:main Jan 17, 2024
47 checks passed
@dellis1972 dellis1972 deleted the WI1922983 branch January 17, 2024 11:39
grendello added a commit that referenced this pull request Jan 17, 2024
* main:
  [Xamarin.Android.Build.Tasks] Add check for aapt2 invalid data path error (#8640)
  [Xamarin.Android.Build.Tasks] fix warning when missing `proguard-android.txt` (#8641)
  LEGO: Merge pull request 8642
  Fix ServerCertificateCustomValidator on API 21-23 (#8637)
grendello added a commit that referenced this pull request Jan 17, 2024
* main:
  [Xamarin.Android.Build.Tasks] Add check for aapt2 invalid data path error (#8640)
jonathanpeppers pushed a commit that referenced this pull request Feb 6, 2024
…rror (#8640)

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1922983

Our error matching in Aapt2.cs did not include a new error message which
has been introduced. As a result we got a APT2000 error instead of an
actual error message which we get for other errors.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants