[release/8.0.2xx] [build] keep $(DotNetAndroidManifestVersionBand) on 8.0.100 #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/xamarin/xamarin-android/blob/2ff1a5f67d6da4ebac507a1b248809388f23e7c7/eng/Versions.props#L15 As we moved to the .NET 8.0.200 SDK, we inadvertently changed the version band of the Android workload: Microsoft.NET.Sdk.Android.Manifest-8.0.200 This would prevent 8.0.100 .NET SDKs from using the latest Android workload. Pin `$(DotNetAndroidManifestVersionBand)` to 8.0.100 to fix this.
pjcollins
reviewed
Mar 27, 2024
eng/Versions.props
Outdated
| @@ -22,6 +22,6 @@ | |||
| <DotNetMonoManifestVersionBand>8.0.100</DotNetMonoManifestVersionBand> | |||
| <DotNetEmscriptenManifestVersionBand>8.0.100</DotNetEmscriptenManifestVersionBand> | |||
| <!-- NOTE: sometimes we hardcode this when transitioning to new version bands --> | |||
| <DotNetAndroidManifestVersionBand>$(DotNetPreviewVersionBand)</DotNetAndroidManifestVersionBand> | |||
| <DotNetAndroidManifestVersionBand>8.0.100</DotNetAndroidManifestVersionBand> | |||
There was a problem hiding this comment.
I'm not seeing this used anywhere, should we update Microsoft.NET.Sdk.Android.proj to use this instead of $(DotNetSdkManifestsFolder)?
There was a problem hiding this comment.
Trying the other property now, (exactly what release/7.0.4xx has).
There was a problem hiding this comment.
This one seems to work:
But letting CI finish.
pjcollins
approved these changes
Mar 27, 2024
|
I think we can ignore the one test failure: |
jonathanpeppers
merged commit 0d97e20
into
dotnet:release/8.0.2xx
44 of 46 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/xamarin-android/blob/2ff1a5f67d6da4ebac507a1b248809388f23e7c7/eng/Versions.props#L15
As we moved to the .NET 8.0.200 SDK, we inadvertently changed the version band of the Android workload:
This would prevent 8.0.100 .NET SDKs from using the latest Android workload.
Pin
$(DotNetAndroidManifestVersionBand)to 8.0.100 to fix this.