[installers] Ship NuGet* assemblies needed by <AndroidMavenLibrary>.

[jpobst]

Fixes: #9037

Attempting to use <AndroidMavenLibrary> in Visual Studio 17.11 P3, which ships .NET 9 P5, like this:

<ItemGroup>
  <AndroidMavenLibrary Include="com.squareup.okhttp3:okhttp" Version="4.9.3" />
</ItemGroup>

gives you the error:

1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.5.308\tools\Xamarin.Android.Bindings.JavaDependencyVerification.targets(27,5): error XAJDV7028: System.IO.FileNotFoundException: Could not load file or assembly 'NuGet.ProjectModel, Version=6.9.1.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The specified file cannot be found.
1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.5.308\tools\Xamarin.Android.Bindings.JavaDependencyVerification.targets(27,5): error XAJDV7028: File name: 'NuGet.ProjectModel, Version=6.9.1.3, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.5.308\tools\Xamarin.Android.Bindings.JavaDependencyVerification.targets(27,5): error XAJDV7028:    at Xamarin.Android.Tasks.NuGetPackageVersionFinder.Create(String filename, TaskLoggingHelper log)
1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.5.308\tools\Xamarin.Android.Bindings.JavaDependencyVerification.targets(27,5): error XAJDV7028:    at Xamarin.Android.Tasks.DependencyResolver..ctor(String lockFile, TaskLoggingHelper log) in /Users/runner/work/1/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Tasks/JavaDependencyVerification.cs:line 124
1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.5.308\tools\Xamarin.Android.Bindings.JavaDependencyVerification.targets(27,5): error XAJDV7028:    at Xamarin.Android.Tasks.JavaDependencyVerification.RunTask() in /Users/runner/work/1/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Tasks/JavaDependencyVerification.cs:line 77
1>C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-preview.5.308\tools\Xamarin.Android.Bindings.JavaDependencyVerification.targets(27,5): error XAJDV7028:    at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in /Users/runner/work/1/s/xamarin-android/external/xamarin-android-tools/src/Microsoft.Android.Build.BaseTasks/AndroidTask.cs:line 25

We need to ship NuGet.ProjectModel.dll as well as its dependencies to ensure they are always available to our MSBuild tasks.

Note that NuGet does not ship .pdb files for these assemblies in their NuGet packages. We will need to exclude these assemblies from .pdb checking.

[jonathanpeppers]

For the pdb files, we might get a SymbolCheck failure when we go to insert into VS. I'm not sure if it would somehow be able to "find" the symbols for these assemblies, since it is NuGet.

It would be OK if SymbolCheck fails, we just will have to update an exclusion list.

[pjcollins]

Could we also add a test for the failing AndroidMavenLibrary case?

[jpobst]

Could we also add a test for the failing AndroidMavenLibrary case?

Unfortunately I don't think that's possible, as it only occurs inside Visual Studio. Running from the command line succeeds, presumably from a copy of these libraries already loaded into the dotnet process.

We do have tests for the basic AndroidMavenLibrary case which succeed on CI:

android/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BindingBuildTest.cs

Lines 800 to 818 in 3ab04df

	[Test]
	public void AndroidMavenLibrary ()
	{
	// Test that <AndroidMavenLibrary> downloads .jar from Maven and successfully binds it
	var item = new BuildItem ("AndroidMavenLibrary", "com.google.auto.value:auto-value-annotations");
	item.Metadata.Add ("Version", "1.10.4");
	var proj = new XamarinAndroidBindingProject {
	Jars = { item }
	};
	using (var b = CreateDllBuilder ()) {
	Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
	// Ensure the generated file exists
	var cs_file = b.Output.GetIntermediaryPath (Path.Combine ("generated", "src", "Com.Google.Auto.Value.AutoValueAttribute.cs"));
	FileAssert.Exists (cs_file);
	}
	}

[jonathanpeppers]

@jpobst @pjcollins do we have .pdb's for these files?

See: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2208678/

[jpobst]

No, they do not have any in their packages, ex:

https://nuget.info/packages/NuGet.ProjectModel/6.11.0

[jonathanpeppers]

We found you can download them like:

> dotnet-symbol "D:\Downloads\nuget.projectmodel.6.11.0\lib\netstandard2.0\NuGet.ProjectModel.dll"
Downloading from
https://msdl.microsoft.com/download/symbols/
Writing: D:\Downloads\nuget.projectmodel.6.11.0\lib\netstandard2.0\NuGet.ProjectModel.pdb

I think the plan is @pjcollins is going to add a step to the release pipeline where we won't have to actually ship these, but VS will have them.