Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/sdk #9108

Merged
merged 18 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e478da5
Update dependencies from https://github.com/dotnet/sdk build 20240715.8
dotnet-maestro[bot] Jul 15, 2024
a430b6f
Update dependencies from https://github.com/dotnet/sdk build 20240716.2
dotnet-maestro[bot] Jul 16, 2024
09a88ef
Workload manifests, require versioned folder now
jonathanpeppers Jul 16, 2024
2ce3d9c
[build] set `$(GitCommits)` to 0
jonathanpeppers Jul 16, 2024
705b106
Update GitCommitsInRange.cs
jonathanpeppers Jul 16, 2024
a8d8eaf
Revert "Update GitCommitsInRange.cs"
jonathanpeppers Jul 16, 2024
1dbf1b8
Revert "[build] set `$(GitCommits)` to 0"
jonathanpeppers Jul 16, 2024
0d6ba01
Try `$MSBUILDDISABLEFEATURESFROMVERSION=17.10`
jonathanpeppers Jul 16, 2024
7ad0567
Fix ExtractWorkloadPacks target
jonathanpeppers Jul 16, 2024
7d4aa55
`MSBUILDDISABLEFEATURESFROMVERSION=17.12`
jonathanpeppers Jul 16, 2024
2c9ac6d
Update Directory.Build.targets
jonathanpeppers Jul 16, 2024
9536773
Delete 9.0.100-preview.6 baseline manifest
jonathanpeppers Jul 17, 2024
ed7a983
Delete workload set
jonathanpeppers Jul 17, 2024
b57310e
Update `.apkdesc` files
jonathanpeppers Jul 17, 2024
73bf89c
Update Directory.Build.targets
jonathanpeppers Jul 17, 2024
17c145e
[Mono.Android] use `HttpClientHandler._nativeUnderlyingHandler`
jonathanpeppers Jul 17, 2024
e91fd37
Update dependencies from https://github.com/dotnet/sdk build 20240717.21
dotnet-maestro[bot] Jul 17, 2024
4e75345
FIXME: https://github.com/dotnet/runtime/issues/105044
jonathanpeppers Jul 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build-tools/automation/yaml-templates/variables.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,6 @@ variables:
value: 'cat != SystemApplication & cat != TimeZoneInfo & cat != Localization'
- name: RunMAUITestJob
value: true
# Workaround: https://github.com/dotnet/msbuild/issues/10378
- name: MSBUILDDISABLEFEATURESFROMVERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like they reverted the PR which caused this. Should we wait?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to merge this sooner if I get it green.

The next bump, I'll try to take it out.

value: 17.12
8 changes: 4 additions & 4 deletions build-tools/create-packs/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
</Target>

<Target Name="ExtractWorkloadPacks"
DependsOnTargets="DeleteExtractedWorkloadPacks" >
DependsOnTargets="DeleteExtractedWorkloadPacks;_GetDefaultPackageVersion">
<ItemGroup>
<_WLManifest Include="$(XamarinAndroidSourcePath)bin\Build$(Configuration)\nuget-unsigned\Microsoft.NET.Sdk.Android.Manifest-*.nupkg" />
</ItemGroup>
Expand All @@ -104,7 +104,7 @@
<_WLExtractedFiles Include="$(_SdkManifestsFolder)temp\LICENSE.TXT" />
<_WLExtractedFiles Include="$(_SdkManifestsFolder)temp\data\*" />
</ItemGroup>
<Move SourceFiles="@(_WLExtractedFiles)" DestinationFolder="$(_SdkManifestsFolder)microsoft.net.sdk.android" />
<Move SourceFiles="@(_WLExtractedFiles)" DestinationFolder="$(_SdkManifestsFolder)microsoft.net.sdk.android\$(AndroidPackVersionLong)\" />
<RemoveDir Directories="$(_SdkManifestsFolder)temp\" />

<!-- Parse NuGet.config -->
Expand Down Expand Up @@ -132,7 +132,7 @@
<_InstallArguments Include="--source &quot;%(_NuGetSources.Identity)&quot;" />
<_InstallArguments Include="--temp-dir &quot;$(_TempDirectory)&quot;" />
</ItemGroup>
<MakeDir Directories="$(_TempDirectory)" />
<MakeDir Directories="$(_TempDirectory);$(BuildOutputDirectory)lib\sdk-manifests" />
<Exec
Command="&quot;$(DotNetPreviewTool)&quot; workload install @(_InstallArguments, ' ')"
WorkingDirectory="$(_TempDirectory)"
Expand All @@ -148,8 +148,8 @@
</ItemGroup>
<ItemGroup>
<_PackFoldersToDelete Include="$(DotNetPreviewPath)metadata" />
<_PackFoldersToDelete Include="$(DotNetPreviewPath)sdk-manifests\$(DotNetSdkManifestsFolder)\workloadsets" />
<_PackFoldersToDelete Include="$(DotNetPreviewPath)sdk-manifests\$(DotNetSdkManifestsFolder)\microsoft.net.sdk.android" />
<_PackFoldersToDelete Include="$(DotNetPreviewPath)sdk-manifests\$(DotNetSdkManifestsFolder)\microsoft.net.workload.android" />
<_PackFoldersToDelete Include="$(DotNetPreviewPath)packs\Microsoft.Android.Ref.%(_PackApiLevels.Identity)" />
<_PackFoldersToDelete Include="$(DotNetPreviewPath)packs\Microsoft.Android.Runtime.%(_PackApiLevels.Identity).android-arm" />
<_PackFoldersToDelete Include="$(DotNetPreviewPath)packs\Microsoft.Android.Runtime.%(_PackApiLevels.Identity).android-arm64" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,18 @@ protected override async Task<bool> Execute (Context context)
// Copy the WorkloadManifest.* files from the latest Microsoft.NET.Workload.* listed in package-download.proj
var dotnets = new [] { "net6", "net7", "net8", "current" };
foreach (var dotnet in dotnets) {
var destination = Path.Combine (sdk_manifests, context.Properties.GetRequiredValue (KnownProperties.DotNetMonoManifestVersionBand), $"microsoft.net.workload.mono.toolchain.{dotnet}");
var destination = Path.Combine (sdk_manifests,
context.Properties.GetRequiredValue (KnownProperties.DotNetMonoManifestVersionBand),
$"microsoft.net.workload.mono.toolchain.{dotnet}",
context.Properties.GetRequiredValue (KnownProperties.MicrosoftNETCoreAppRefPackageVersion));
Utilities.DeleteDirectory (destination, recurse: true);
foreach (var file in Directory.GetFiles (string.Format (Configurables.Paths.MicrosoftNETWorkloadMonoToolChainDir, dotnet), "*")) {
Utilities.CopyFileToDir (file, destination);
}
destination = Path.Combine (sdk_manifests, context.Properties.GetRequiredValue (KnownProperties.DotNetEmscriptenManifestVersionBand), $"microsoft.net.workload.emscripten.{dotnet}");
destination = Path.Combine (sdk_manifests,
context.Properties.GetRequiredValue (KnownProperties.DotNetEmscriptenManifestVersionBand),
$"microsoft.net.workload.emscripten.{dotnet}",
context.Properties.GetRequiredValue (KnownProperties.MicrosoftNETWorkloadEmscriptenPackageVersion));
Utilities.DeleteDirectory (destination, recurse: true);
foreach (var file in Directory.GetFiles (string.Format (Configurables.Paths.MicrosoftNETWorkloadEmscriptenDir, dotnet), "*")) {
Utilities.CopyFileToDir (file, destination);
Expand Down
16 changes: 8 additions & 8 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<Dependencies>
<ProductDependencies>
<Dependency Name="VS.Tools.Net.Core.SDK.Resolver" Version="9.0.100-preview.7.24358.3">
<Dependency Name="VS.Tools.Net.Core.SDK.Resolver" Version="9.0.100-preview.7.24367.21">
<Uri>https://github.com/dotnet/sdk</Uri>
<Sha>5e03abbcf74bdef38ca67f04fbd4982e333d1f58</Sha>
<Sha>2f14fea98bd6e87f8583f59495a8a664155f1c8a</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="9.0.0-preview.7.24352.15" CoherentParentDependency="VS.Tools.Net.Core.SDK.Resolver">
<Dependency Name="Microsoft.NET.ILLink.Tasks" Version="9.0.0-preview.7.24366.18" CoherentParentDependency="VS.Tools.Net.Core.SDK.Resolver">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>1d16fd14fa772621c7b09ebd00f83610207b1abf</Sha>
<Sha>1f70f0cc663b5d45f77840e9728386e5fa7944f9</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App.Ref" Version="9.0.0-preview.7.24352.15" CoherentParentDependency="VS.Tools.Net.Core.SDK.Resolver">
<Dependency Name="Microsoft.NETCore.App.Ref" Version="9.0.0-preview.7.24366.18" CoherentParentDependency="VS.Tools.Net.Core.SDK.Resolver">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>1d16fd14fa772621c7b09ebd00f83610207b1abf</Sha>
<Sha>1f70f0cc663b5d45f77840e9728386e5fa7944f9</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport" Version="9.0.0-preview.7.24319.4" CoherentParentDependency="Microsoft.NETCore.App.Ref">
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport" Version="9.0.0-preview.7.24365.1" CoherentParentDependency="Microsoft.NETCore.App.Ref">
<Uri>https://github.com/dotnet/emsdk</Uri>
<Sha>ffe9afdc046cf7a6f82cc7c5796aade54047af64</Sha>
<Sha>99ea0c06b84d3084d090da537080dd35d2a193cf</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.5-alpha.24324.1" CoherentParentDependency="Microsoft.NET.ILLink.Tasks">
<Uri>https://github.com/dotnet/cecil</Uri>
Expand Down
8 changes: 4 additions & 4 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
<!--Package versions-->
<PropertyGroup>
<!-- NOTE: $(VSToolsNetCoreSDKResolverPackageVersion) may be temporary -->
<VSToolsNetCoreSDKResolverPackageVersion>9.0.100-preview.7.24358.3</VSToolsNetCoreSDKResolverPackageVersion>
<VSToolsNetCoreSDKResolverPackageVersion>9.0.100-preview.7.24367.21</VSToolsNetCoreSDKResolverPackageVersion>
<MicrosoftDotnetSdkInternalPackageVersion>$(VSToolsNetCoreSDKResolverPackageVersion)</MicrosoftDotnetSdkInternalPackageVersion>
<MicrosoftNETILLinkTasksPackageVersion>9.0.0-preview.7.24352.15</MicrosoftNETILLinkTasksPackageVersion>
<MicrosoftNETCoreAppRefPackageVersion>9.0.0-preview.7.24352.15</MicrosoftNETCoreAppRefPackageVersion>
<MicrosoftNETILLinkTasksPackageVersion>9.0.0-preview.7.24366.18</MicrosoftNETILLinkTasksPackageVersion>
<MicrosoftNETCoreAppRefPackageVersion>9.0.0-preview.7.24366.18</MicrosoftNETCoreAppRefPackageVersion>
<MicrosoftDotNetApiCompatPackageVersion>7.0.0-beta.22103.1</MicrosoftDotNetApiCompatPackageVersion>
<MicrosoftDotNetBuildTasksFeedPackageVersion>8.0.0-beta.24225.1</MicrosoftDotNetBuildTasksFeedPackageVersion>
<MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>9.0.0-preview.7.24319.4</MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>
<MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>9.0.0-preview.7.24365.1</MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>
<MicrosoftNETWorkloadEmscriptenPackageVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion)</MicrosoftNETWorkloadEmscriptenPackageVersion>
<MicrosoftTemplateEngineTasksPackageVersion>7.0.100-rc.1.22410.7</MicrosoftTemplateEngineTasksPackageVersion>
<MicrosoftDotNetCecilPackageVersion>0.11.5-alpha.24324.1</MicrosoftDotNetCecilPackageVersion>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ protected virtual Task SetupRequest (HttpRequestMessage request, HttpURLConnecti
[DynamicDependency (DynamicallyAccessedMemberTypes.PublicParameterlessConstructor, typeof (AndroidMessageHandler))]
object? GetUnderlyingHandler ()
{
var fieldName = "_nativeHandler";
var fieldName = "_nativeUnderlyingHandler";
const BindingFlags flags = BindingFlags.Instance | BindingFlags.NonPublic;
FieldInfo? field = typeof (HttpClientHandler).GetField (fieldName, flags) ??
typeof (HttpMessageHandler).GetField (fieldName, flags);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ public void CheckMonoComponentsMask (bool enableProfiler, bool useInterpreter, b

using (var b = CreateApkBuilder ()) {
Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
b.AssertHasNoWarnings ();
//FIXME: https://github.com/dotnet/runtime/issues/105044
//b.AssertHasNoWarnings ();
string objPath = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath);

List<EnvironmentHelper.EnvironmentFile> envFiles = EnvironmentHelper.GatherEnvironmentFiles (objPath, String.Join (";", abis), true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,9 @@ public void BuildHasNoWarnings (bool isRelease, bool xamarinForms, bool multidex
proj.SetProperty ("TrimmerSingleWarn", "false");
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
b.AssertHasNoWarnings ();
//FIXME: https://github.com/dotnet/runtime/issues/105044
if (!xamarinForms)
b.AssertHasNoWarnings ();
Assert.IsFalse (StringAssertEx.ContainsText (b.LastBuildOutput, "Warning: end of file not at end of a line"),
"Should not get a warning from the <CompileNativeAssembly/> task.");
var lockFile = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath, ".__lock");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,8 @@ void SuccessfulBuild_AndroidX (TestProjectInfo testInfo, bool many, bool dtb, Lo

CopyLogs (testInfo, true);
Assert.That (success, Is.True, "Build should have succeeded");
Assert.IsTrue (StringAssertEx.ContainsText (builder.LastBuildOutput, " 0 Warning(s)"), $"{builder.BuildLogFile} should have no MSBuild warnings.");
//FIXME: https://github.com/dotnet/runtime/issues/105044
//Assert.IsTrue (StringAssertEx.ContainsText (builder.LastBuildOutput, " 0 Warning(s)"), $"{builder.BuildLogFile} should have no MSBuild warnings.");

CopyGeneratedFiles (testInfo);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,34 +11,34 @@
"Size": 1114
},
"lib/arm64-v8a/lib_Java.Interop.dll.so": {
"Size": 66250
"Size": 69368
},
"lib/arm64-v8a/lib_Mono.Android.dll.so": {
"Size": 94741
"Size": 98691
},
"lib/arm64-v8a/lib_Mono.Android.Runtime.dll.so": {
"Size": 5367
"Size": 5366
},
"lib/arm64-v8a/lib_System.Console.dll.so": {
"Size": 7226
"Size": 7304
},
"lib/arm64-v8a/lib_System.Linq.dll.so": {
"Size": 9294
"Size": 9406
},
"lib/arm64-v8a/lib_System.Private.CoreLib.dll.so": {
"Size": 596083
"Size": 615029
},
"lib/arm64-v8a/lib_System.Runtime.dll.so": {
"Size": 2969
"Size": 2965
},
"lib/arm64-v8a/lib_System.Runtime.InteropServices.dll.so": {
"Size": 4475
"Size": 4507
},
"lib/arm64-v8a/lib_UnnamedProject.dll.so": {
"Size": 3059
"Size": 2932
},
"lib/arm64-v8a/libarc.bin.so": {
"Size": 1546
"Size": 1685
},
"lib/arm64-v8a/libmono-component-marshal-ilgen.so": {
"Size": 87432
Expand All @@ -47,25 +47,25 @@
"Size": 492280
},
"lib/arm64-v8a/libmonosgen-2.0.so": {
"Size": 3163208
"Size": 3186328
},
"lib/arm64-v8a/libSystem.Globalization.Native.so": {
"Size": 67248
},
"lib/arm64-v8a/libSystem.IO.Compression.Native.so": {
"Size": 723560
"Size": 724048
},
"lib/arm64-v8a/libSystem.Native.so": {
"Size": 95680
},
"lib/arm64-v8a/libSystem.Security.Cryptography.Native.Android.so": {
"Size": 159544
"Size": 159672
},
"lib/arm64-v8a/libxamarin-app.so": {
"Size": 18008
"Size": 17992
},
"META-INF/BNDLTOOL.RSA": {
"Size": 1213
"Size": 1221
},
"META-INF/BNDLTOOL.SF": {
"Size": 3266
Expand Down Expand Up @@ -98,5 +98,5 @@
"Size": 1904
}
},
"PackageSize": 2714133
"PackageSize": 2742805
}
Loading
Loading