[Mono.Android] [Preserve] now has [Obsolete(error:true)]
#9109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: TobiasBuchholz/Plugin.Firebase#144 (comment) Even since .NET 6 (in e604833), we have marked `[Preserve]` as `[Obsolete]`. However, you could still use the attribute *thinking* it might do something, while it actually does nothing. Let's add in .NET 9: * `error: true` so you get a build error * An actual docs link (the best one I could find)
|
Apparently, there are some cases where |
|
I'm going to rework this to:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: TobiasBuchholz/Plugin.Firebase#144 (comment)
Even since .NET 6 (in e604833), we have marked
[Preserve]as[Obsolete]. However, you could still use the attribute thinking it might do something, while it actually does nothing.Let's add in .NET 9:
error: trueso you get a build errorAn actual docs link (the best one I could find)