[Xamarin.Android.Build.Tasks] Bump MinimumSupportedJavaVersion=17

[jonpryor]

Context: #9159 (comment)

Bump $(MinimumSupportedJavaVersion) to 17.0, and base this value on the Configurables.Defaults.MicrosoftOpenJDK17Version value so that if (when) we bump the JDK we build against, the major version value of $(MinimumSupportedJavaVersion) follows suit.

Additionally, remove the $(MinimumSupportedJavaVersion) definition in Microsoft.Android.Sdk.DefaultProperties.targets so that it's only defined in one location.

[jonathanpeppers]

Is this raising the min JDK to 17? for our whole product?

Should we consider:

• JDK 11 minimum for .NET 9
• JDK 17 minimum for .NET 10

Just wondering what might break if this goes out in RC 2.

[jonpryor]

@jonathanpeppers asked:

Is this raising the min JDK to 17? for our whole product?

Yes.

Which may sound bananas, but:

• Visual Studio (Windows) has installed JDK 17 since at least last fall.

• The VSCode MAUI Extension checks for JDK 17:

  Android components:
  	- Java SDK: installed version '17.0.7'
  

• .NET 8's InstallAndroidDependencies target would provision JDK 17: https://github.com/xamarin/monodroid/blob/release/8.0.4xx/tools/msbuild/Xamarin.Android.Common.Debugging.targets#L397-L443

TODO? What did/does VSMac provision? (And should we even care?)

Thus, who could/would still be using JDK-11? Who could this break?

Then there's the "real" reason I'm suggesting this: bumping $(MinimumSupportedJavaVersion) means it's consistent with $(JavaSdkVersion) and @(JavaDependency). Without this change, we'll have a possible scenario of:

1. JDK-11 is installed and preferred (which is my current machine, via $HOME/.config/xbuild/monodroid-config.xml)

2. I run dotnet build -t:InstallAndroidDependencies …, on .NET 9, and it errors out (now! with .NET 9 P7):

   error : Unable to install the Java SDK into `/Library/Java/JavaVirtualMachines/microsoft-11.jdk/Contents/Home`. Please set `$(JavaSdkDirectory)` to a valid non-administrator path.
   

   It errors out because InstallAndroidDependencies wants to provision JDK 17, but my current system configured JDK is JDK 11.

Bumping $(MinimumSupportedJavaVersion) is the "easy and straightforward" way to resolve this. It would instead cause my machine to produce a XA5300 error that my JDK is too old.

[jonpryor]

Also, I don't think any of our unit tests have used JDK-11 for quite some time (please correct me if I'm wrong), so it's entirely plausible that we don't fully work on JDK-11 now…

[jonathanpeppers]

If it breaks someone, they have the workaround for their project:

<MinimumSupportedJavaVersion>11.0</MinimumSupportedJavaVersion>

So, I think we should just put this in RC 2 release notes, and see if anything goes wrong.