Add Conditional Inputs for _GeneratePackageManagerJava and _GenerateJavaStubs #9319
+85
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
requested review from
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Sep 25, 2024
dellis1972
commented
Sep 25, 2024
|
Draft Commit Message: [Xamarin.Android.Build.Tasks] Add Inputs for _GenerateJavaStubs (#9319)
Context: https://github.com/xamarin/monodroid/pull/1547
This commit updates the Inputs for the `_GenerateJavaStubs` and
`_GeneratePackageManagerJava` targets so that the
`@(AndroidEnvironment)` and `@(LibraryEnvironments)` items are only
included when we are building a release build, or a build which
embeds the assemblies into the apk.
This is so that we can eventually fast deploy these files to the
device; see also xamarin/monodroid#1547.
To *not* attempt to (eventually) fast deploy `@(AndroidEnvironment)`
and `@(LibraryEnvironments)`, set the (*internal*!) MSBuild property
`$(_AndroidFastDeployEnvironmentFiles)` to False.
A new unit test has been added to make sure that the environment
values can be used correctly on device.I'm not certain about the |
jonpryor
reviewed
Sep 26, 2024
jonpryor
reviewed
Sep 26, 2024
|
I found a bug, don't merge it. |
grendello
approved these changes
Sep 26, 2024
|
@dellis1972:
I've restarted the tests just in case it's sporadic… |
This test is going to fail untl the monodroid side is merged. |
jonathanpeppers
pushed a commit
that referenced
this pull request
Sep 30, 2024
Context: xamarin/monodroid#1547 This commit updates the Inputs for the `_GenerateJavaStubs` and `_GeneratePackageManagerJava` targets so that the `@(AndroidEnvironment)` and `@(LibraryEnvironments)` items are only included when we are building a release build, or a build which embeds the assemblies into the apk. This is so that we can eventually fast deploy these files to the device; see also xamarin/monodroid#1547. To *not* attempt to (eventually) fast deploy `@(AndroidEnvironment)` and `@(LibraryEnvironments)`, set the (*internal*!) MSBuild property `$(_AndroidFastDeployEnvironmentFiles)` to False. A new unit test has been added to make sure that the environment values can be used correctly on device.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the inputs for
_GenerateJavaStubsand_GeneratePackageManagerJavaso that the@(AndroidEnvironment)and@(LibraryEnvironments)items are only included if we are building a release build. Or a build which embeds the assemblies into the apk.This is so that we can evantually fast deploy these files to the device via https://github.com/xamarin/monodroid/pull/1547.
A new unit test has been added to make sure that the environment values can be used correctly on device.