[XABT] Update AndroidGradleProject Bind and Pack defaults #9341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dbdc5fa Updates the default values of the `%(Bind)` and `%(Pack)` metadata forwarded to the created `@(AndroidLibrary)` item to better match the defaults on that item. Leaving these empty did not allow the defaults declared in the `AndroidLibrary` ItemDefinitionGroup to be used as expected in commit dbdc5fa.
pjcollins
requested review from
dellis1972 and
jonathanpeppers
as code owners
dellis1972
approved these changes
Sep 27, 2024
jonathanpeppers
approved these changes
Sep 27, 2024
jonathanpeppers
pushed a commit
that referenced
this pull request
Sep 30, 2024
) Context: dbdc5fa Updates the default values of the `%(Bind)` and `%(Pack)` metadata forwarded to the created `@(AndroidLibrary)` item to better match the defaults on that item (True, by default). Leaving these empty did not allow the defaults declared in the `@(AndroidLibrary)` ItemDefinitionGroup to be used as expected in commit dbdc5fa. This allows the compiled output of `@(AndroidGradleProject)` to be bound, making it usable to the containing C# project.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dbdc5fa
Updates the default values of the
%(Bind)and%(Pack)metadataforwarded to the created
@(AndroidLibrary)item to better match thedefaults on that item. Leaving these empty did not allow the defaults
declared in the
AndroidLibraryItemDefinitionGroup to be used asexpected in commit dbdc5fa.