Move DSO wrapping code to BuildApk #9349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/move-dso-state
branch
from
bbbe516
to
a8e267c
Compare
grendello
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
...d.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.AssemblyResolution.targets
Show resolved
Hide resolved
grendello
force-pushed
the
dev/grendel/move-dso-state
branch
3 times, most recently
from
28e8928
to
873bbe7
Compare
In order to avoid having to register a task object in the `PrepareDSOWrapperState`, move the DSO wrapper stub library discovery code to `BuildApk`.
grendello
force-pushed
the
dev/grendel/move-dso-state
branch
from
873bbe7
to
1b167b9
Compare
dellis1972
reviewed
Oct 14, 2024
jonathanpeppers
approved these changes
Oct 14, 2024
dellis1972
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid having to register a task object in the
PrepareDSOWrapperState, move the DSO wrapper stub library discoverycode to
BuildApk.