[release/9.0.1xx] Use stable 35.0.x branding #9446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 0f2a323 Context: 4ea5dbb Brings in stable versioning changes from previous .NET 8 and .NET 7 release branches. We've historically added a few new version properties to represent the stable version and calculate the patch delta. `$(AndroidPackVersion)` has been updated to "reset" the commit distance.
pjcollins
commented
Oct 22, 2024
| <IsStableBuild Condition=" '$(AndroidPackVersionSuffix)' == 'rtm' and $(XAVersionBranch.StartsWith('release/')) ">true</IsStableBuild> | ||
| </PropertyGroup> | ||
| <Message Text="XAVersionInfo: $(XAVersionBranch)/$(XAVersionHash) - PackVersion: $(AndroidPackVersionLong) MSIVersion: $(AndroidMSIVersion) IsStable: $(IsStableBuild)" /> |
There was a problem hiding this comment.
I decided to add some logging here to make it easier to look through logs, and it's probably worth us looking at this again for .NET 10 to simplify the set of changes needed.
jonathanpeppers
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 0f2a323
Context: 4ea5dbb
Brings in stable versioning changes from previous .NET 8 and .NET 7
release branches. We've historically added a few new version properties
to represent the stable version and calculate the patch delta.
$(AndroidPackVersion)has been updated to "reset" the commit distance.