[Xamarin.Android.Build.Tasks] fix Debug mode and $(PublishTrimmed) #9452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
reviewed
Oct 23, 2024
| [Test] | ||
| public void CheckDebugModeWithTrimming () | ||
| { | ||
| bool usesAssemblyStores = false; |
There was a problem hiding this comment.
Did you want to make this a parameter? The value never changes from false.
There was a problem hiding this comment.
The test didn't work with true, it doesn't seem to find any assembly stores. This could be another bug? But I manually checked and saw the assemblies inside.
There was a problem hiding this comment.
It doesn't find any assembly stores because there are no assemblies in the build (the _Shrunk* item groups are empty)
There was a problem hiding this comment.
This change fixes the @(_Shrunk*) item groups, I see them inside the _PrepareAssemblies target now:
There was a problem hiding this comment.
Must be with FastDev enabled, because without it I don't see the _Shrunk* groups populated :(
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There is a problem if you have the combination:
* `Configuration=Debug`
* `PublishTrimmed=true`
We emit an `XA0119` warning with this combination, as there is not a
good reason to do it.
But unfortunately, the build will be completely broken as all the .NET
assemblies don't make it to the `.apk`! I could reproduce this in a
test.
The fix is that the logic in the `<ProcessAssemblies/>` MSBuild task
needs to match the logic in the `_PrepareAssemblies` MSBuild target:
if (PublishTrimmed && !AndroidIncludeDebugSymbols) {
//...
ShrunkAssemblies = shrunkAssemblies.ToArray ();
}
Should match:
<ItemGroup Condition=" '$(PublishTrimmed)' == 'true' and '$(AndroidIncludeDebugSymbols)' != 'true' ">
With the preceding `<ItemGroup>` having the inverse of this `Condition`.
Going forward, we could probably refactor some of this logic to make
things simpler, but this is a reasonable fix for now.
jonathanpeppers
force-pushed
the
DebugModeTrimming
branch
from
4b5f0b5 to
e5609d4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok, the fix was actually in C#, in the |
grendello
added a commit
that referenced
this pull request
Oct 28, 2024
grendello
approved these changes
Oct 30, 2024
jonathanpeppers
added a commit
that referenced
this pull request
Nov 8, 2024
…9452) There is a problem if you have the combination: * `Configuration=Debug` * `PublishTrimmed=true` We emit an `XA0119` warning with this combination, as there is not a good reason to do it. But unfortunately, the build will be completely broken as all the .NET assemblies don't make it to the `.apk`! I could reproduce this in a test. The fix is that the logic in the `<ProcessAssemblies/>` MSBuild task: if (PublishTrimmed && !AndroidIncludeDebugSymbols) { //... ShrunkAssemblies = shrunkAssemblies.ToArray (); } Has a case, where we did not fill out the `ShrunkAssemblies` `[Output]` item group: if (!AndroidIncludeDebugSymbols) { // existing logic... } else { ShrunkAssemblies = OutputAssemblies; } Going forward, we could probably refactor some of this logic to make things simpler, but this is a reasonable fix for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem if you have the combination:
Configuration=DebugPublishTrimmed=trueWe emit an
XA0119warning with this combination, as there is not a good reason to do it.But unfortunately, the build will be completely broken as all the .NET assemblies don't make it to the
.apk! I could reproduce this in a test.The fix is that the logic in the
<ProcessAssemblies/>MSBuild task:Has a case, where we did not fill out the
ShrunkAssemblies[Output]item group:Going forward, we could probably refactor some of this logic to make things simpler, but this is a reasonable fix for now.