[Xamarin.Android.Build.Tasks] close XAAssemblyResolvers

[jonathanpeppers]

Context: https://discord.com/channels/732297728826277939/732297916680765551/1308554103206580244
Fixes: #9133
Context: 86260ed

Various customers have been reporting UnauthorizedAccessExceptions in incremental builds, which seems to be a new problem in .NET 9. We were not able to reproduce the issue locally, but with the number of reports it seems to be a real issue.

One customer shared a MSBuild.dmp file (while the file was locked), where I could observe the objects in memory:

MemoryMappedViewStream	132
    Mono.Cecil.PE.Image	100
        Mono.Cecil.ModuleDefinition	100
            Mono.Cecil.TypeDefinition	100
                Mono.Cecil.TypeDefinition[]	100
                    List<Mono.Cecil.TypeDefinition>	1
                        Xamarin.Android.Tasks.NativeCodeGenState [Static variable Xamarin.Android.Tasks.NativeCodeGenState.<Template>k__BackingField]	1

Then realized the problem was:

• We opened some .dll files with Mono.Cecil.

• They were never closed.

• Future incremental build attempts would fail on various operations of the same .dll files.

We were also storing some static state (NativeCodeGenState) to be shared across multiple MSBuild tasks:

public static NativeCodeGenState? Template { get; set; }

NativeCodeGenState also holds a XAAssemblyResolver in a Resolver property. This means this XAAssemblyResolver instance would also be kept alive.

It appears we only use the static Template property for a bool flag, so I changed the property to a bool instead.

After this change, we can safely dispose Resolver instances. I looped over the NativeCodeGenState instances disposing of each Resolver at the end of the <GenerateJavaStubs/> MSBuild task.

[jonathanpeppers]

Actually, there might be a test failure:

Mono.Android.NET_Tests, Java.InteropTests.InvokeVirtualFromConstructorTests.ActivationConstructor
Java.Lang.UnsatisfiedLinkError : No implementation found for void net.dot.jni.test.CallVirtualFromConstructorDerived.calledFromConstructor(int) (tried Java_net_dot_jni_test_CallVirtualFromConstructorDerived_calledFromConstructor and Java_net_dot_jni_test_CallVirtualFromConstructorDerived_calledFromConstructor__I)

[jonathanpeppers]

I still see the UnsatisfiedLinkError, which I'm confused how my changes cause it. It even happens in the Debug build.

[jonpryor]

@jonathanpeppers: My "spider-sense" is that this change is the cause of the test failure.

Before this PR, state.JniAddNativeMethodRegistrationAttributePresent is not modified until after WriteTypeMappings() is invoked:

• android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs

  Line 262 in 6b57cc2

  WriteTypeMappings (state);

• android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs

  Line 435 in 6b57cc2

  if (!tmg.Generate (Debug, SkipJniAddNativeMethodRegistrationAttributeScan, TypemapOutputDirectory, GenerateNativeAssembly)) {

• android/src/Xamarin.Android.Build.Tasks/Utilities/TypeMapGenerator.cs

  Line 162 in 6b57cc2

  state.JniAddNativeMethodRegistrationAttributePresent = skipJniAddNativeMethodRegistrationAttributeScan;

With this change, you're setting NativeCodeGenState.TemplateJniAddNativeMethodRegistrationAttributePresent before WriteTypeMappings() has had a chance to execute, and thus before it has had a chance to set state.JniAddNativeMethodRegistrationAttributePresent. Consequently, NativeCodeGenState.TemplateJniAddNativeMethodRegistrationAttributePresent will always be false, when it needs to be true for Java.Interop-Tests to work.

[jonpryor]

Perhaps all you need to do is "move this line" to be after line 262?

/* 262 */     WriteTypeMappings (state);
/* 263 */     NativeCodeGenState.TemplateJniAddNativeMethodRegistrationAttributePresent = NativeCodeGenState.TemplateJniAddNativeMethodRegistrationAttributePresent || state.JniAddNativeMethodRegistrationAttributePresent;
/* 264 */ }

[jonathanpeppers]

Moving it down, fixes it. It worked before, because NativeCodeGenState.Template had a reference to the object. 👍