-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to dotnet/java-interop/main@e288589d #9721
Conversation
Does It Build™?
Unit tests don't compile because |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Changes: dotnet/java-interop@9b1d878...e288589 * dotnet/java-interop@e288589d: [Java.Interop] Add JniRuntime.JniValueManager.GetPeer() (dotnet/java-interop#1295) * dotnet/java-interop@bbb15b71: [ci] Add dev/* branches to CI trigger (dotnet/java-interop#1297)
Draft commit message: Bump to dotnet/java-interop/main@e288589d (#9721)
Changes: https://github.com/dotnet/java-interop/compare/9b1d8781e8e322849d05efac32119c913b21c192...e288589d92afc9edd9070638ebed72f67e310117
* dotnet/java-interop@e288589d: [Java.Interop] Add JniRuntime.JniValueManager.GetPeer() (dotnet/java-interop#1295)
* dotnet/java-interop@bbb15b71: [ci] Add dev/* branches to CI trigger (dotnet/java-interop#1297) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- external/Java.Interop: Language not supported
Comments suppressed due to low confidence (2)
tests/Mono.Android-Tests/Java.Interop-Tests/Java.InteropTests/AndroidValueManagerContractTests.cs:15
- [nitpick] The class name 'AndroidValueManagerContractTests' could be more descriptive. Consider renaming it to reflect the specific aspect of 'AndroidValueManager' it is testing.
public class AndroidValueManagerContractTests : JniRuntimeJniValueManagerContract {
tests/Mono.Android-Tests/Java.Interop-Tests/Java.InteropTests/AndroidValueManagerContractTests.cs:17
- There is no test to verify the behavior of the 'ValueManagerType' property. Consider adding a test to ensure the override is functioning as expected.
protected override Type ValueManagerType => typeof (Android.Runtime.AndroidValueManager);
Changes: dotnet/java-interop@9b1d878...e288589