[Mono.Android] fix JavaConvert.GetTypeMapping() for NativeAOT
#9864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mono.Android-Tests running on NativeAOT can have a failure such as:
02-28 14:33:38.949 12544 12567 I NUnit : Indexer
02-28 14:33:38.952 12544 12567 E NUnit : [FAIL]
02-28 14:33:38.952 12544 12567 E NUnit : : System.DllNotFoundException : DllNotFound_Linux, xa-internal-api,
02-28 14:33:38.952 12544 12567 E NUnit : dlopen failed: library "xa-internal-api.so" not found
02-28 14:33:38.952 12544 12567 E NUnit : dlopen failed: library "libxa-internal-api.so" not found
02-28 14:33:38.952 12544 12567 E NUnit : dlopen failed: library "xa-internal-api" not found
02-28 14:33:38.952 12544 12567 E NUnit : dlopen failed: library "libxa-internal-api" not found
02-28 14:33:38.952 12544 12567 E NUnit : at System.Runtime.InteropServices.NativeLibrary.LoadLibErrorTracker.Throw(String) + 0x4c
02-28 14:33:38.952 12544 12567 E NUnit : at Internal.Runtime.CompilerHelpers.InteropHelpers.FixupModuleCell(InteropHelpers.ModuleFixupCell*) + 0x134
02-28 14:33:38.952 12544 12567 E NUnit : at Internal.Runtime.CompilerHelpers.InteropHelpers.ResolvePInvokeSlow(InteropHelpers.MethodFixupCell*) + 0x40
02-28 14:33:38.952 12544 12567 E NUnit : at Android.Runtime.RuntimeNativeMethods.monodroid_TypeManager_get_java_class_name(IntPtr klass) + 0x2c
02-28 14:33:38.952 12544 12567 E NUnit : at Java.Interop.TypeManager.GetClassName(IntPtr) + 0x10
02-28 14:33:38.952 12544 12567 E NUnit : at Java.Interop.JavaConvert.GetTypeMapping(IntPtr) + 0x28
02-28 14:33:38.952 12544 12567 E NUnit : at Java.Interop.JavaConvert.FromJniHandle(IntPtr handle, JniHandleOwnership transfer, Type targetType) + 0x84
02-28 14:33:38.952 12544 12567 E NUnit : at Android.Runtime.JavaList.InternalGet(Int32, Type) + 0x90
02-28 14:33:38.952 12544 12567 E NUnit : at Java.InteropTests.JavaListTest`1.Indexer() + 0xfc
02-28 14:33:38.952 12544 12567 E NUnit : at libMono.Android.NET-Tests!<BaseAddress>+0x152f744
02-28 14:33:38.952 12544 12567 E NUnit : at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x10c
We can update `JavaConvert.GetTypeMapping()` to use
`JniEnvironment.Types.GetJniTypeNameFromClass()` the same way it is
done in dotnet/java-interop:
https://github.com/dotnet/java-interop/blob/719e615910923bbce10e74b05bcc6b9585d4e176/src/Java.Interop/Java.Interop/JniEnvironment.Types.cs#L214-L220
With this change the test passes:
02-28 14:46:50.280 13091 13107 I NUnit : Indexer
02-28 14:46:50.281 13091 13107 I NUnit : Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono.Android-Tests running on NativeAOT can have a failure such as:
We can update
JavaConvert.GetTypeMapping()to useJniEnvironment.Types.GetJniTypeNameFromClass()the same way it is done in dotnet/java-interop:https://github.com/dotnet/java-interop/blob/719e615910923bbce10e74b05bcc6b9585d4e176/src/Java.Interop/Java.Interop/JniEnvironment.Types.cs#L214-L220
With this change the test passes: