Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable Annotations for System.Runtime, System.Runtime.Extensions, System.Collections, and System.Runtime.Intrinsics #97

Merged
merged 14 commits into from
Jun 6, 2019
Merged

Nullable Annotations for System.Runtime, System.Runtime.Extensions, System.Collections, and System.Runtime.Intrinsics #97

merged 14 commits into from
Jun 6, 2019

Conversation

terrajobst
Copy link
Contributor

@terrajobst terrajobst commented May 30, 2019 •
edited
Loading

I'll submit separate PRs for the upcoming reference assemblies.

/cc @dotnet/nullablefc @dotnet/fxdc

@terrajobst terrajobst requested review from a team and removed request for a team May 30, 2019 23:48
safern
safern approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits. Looks good to me.

@terrajobst terrajobst changed the title Add notes for review session 1-3 Nullable Annotations for System.Runtime May 31, 2019
@terrajobst terrajobst mentioned this pull request Jun 3, 2019
Closed
@terrajobst terrajobst marked this pull request as ready for review June 6, 2019 00:16
@terrajobst terrajobst changed the title Nullable Annotations for System.Runtime Nullable Annotations for System.Runtime, System.Runtime.Extensions, System.Collections, and System.Runtime.Intrinsics Jun 6, 2019
stephentoub
stephentoub reviewed Jun 6, 2019
View reviewed changes
@terrajobst terrajobst merged commit 18e05dd into dotnet:master Jun 6, 2019
@terrajobst terrajobst deleted the nullable branch June 6, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@tannergooding tannergooding tannergooding left review comments

@safern safern safern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrajobst @stephentoub @tannergooding @safern