Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch dotnet/scenario-tests onto the full code flow #4159

Closed
premun opened this issue Nov 18, 2024 · 4 comments
Closed

Switch dotnet/scenario-tests onto the full code flow #4159

premun opened this issue Nov 18, 2024 · 4 comments
Assignees
@premun
Milestone
Switch to the new...

Comments

@premun
Copy link
Member

premun commented Nov 18, 2024 •
edited
Loading

Context

We have agreed that we want to start dogfooding the flat dependency flow by using the dotnet/scenario-tests repository.
First, we need to implement #4158 though.

Goal

  1. Disable synchronization of scenario-tests via the current pipeline method
  2. Add a code-flow subscription from scenario-tests to the VMR
  3. Add a build of the VMR so that we also have the backflow (can be empty for now)
  4. Add a subscription from the VMR to the scenario-tests repository
  5. Start building/publishing the scenario-tests packages out of the VMR
  6. Disable publishing of the scenario-tests packages in scenario-tests's CI
  7. Make repositories depending on scenario-tests depend on the VMR channel instead
@premun
Copy link
Member Author

premun commented Nov 18, 2024

We can do steps 1 and 2 immediately after #4158 and and have one-way flow only

@premun premun moved this to In Progress in .NET Unified Build Nov 19, 2024
@premun premun self-assigned this Nov 19, 2024
@premun premun moved this from In Progress to Ready in .NET Unified Build Nov 19, 2024
@premun premun removed their assignment Nov 20, 2024
@premun premun changed the title Switch the source-link repo onto the full code flow Switch the scenario-tests repo onto the full code flow Nov 21, 2024
@premun premun self-assigned this Nov 21, 2024
This was referenced Nov 21, 2024
Merged
Merged
@mthalman
Copy link
Member

The original issue body still mentions dotnet/sourcelink. That should be updated to scenario-tests.

This was referenced Dec 4, 2024
Merged
Merged
@premun premun moved this from Ready to In Progress in .NET Unified Build Dec 10, 2024
@premun premun changed the title Switch the scenario-tests repo onto the full code flow Switch dotnet/scenario-tests onto the full code flow Jan 2, 2025
@premun
Copy link
Member Author

premun commented Jan 2, 2025

Forward flow now works: dotnet/dotnet#123
Backflow can only be enabled once we start producing packages from the VMR

@premun premun mentioned this issue Jan 7, 2025
Merged
@premun premun moved this from In Progress to Blocked in .NET Unified Build Jan 14, 2025
@premun
Copy link
Member Author

premun commented Feb 13, 2025

The repo is now on the flat flow only

@premun premun closed this as completed Feb 13, 2025
@github-project-automation github-project-automation bot moved this from Blocked to Done in .NET Unified Build Feb 13, 2025
@premun premun mentioned this issue Feb 24, 2025
Merged
premun added a commit that referenced this issue Feb 24, 2025
@premun
Fix a "no downgrade" merge policy NRE (#4483)
68f8014 
We have a pending TODO where we don't fill the `RequiredUpdates` yet.
However, the merge policy check fails on an NRE if this is null.

Example:
https://github.com/dotnet/scenario-tests/pull/213/checks?check_run_id=37710832910


#3866
#4159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@premun premun

Labels
None yet
Projects
.NET Unified Build
Status: Done
Milestone
Switch to the new flat dependency flo...
Development

No branches or pull requests
2 participants
@premun @mthalman