Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging to the Rollout Scorer #1285

Merged
merged 5 commits into from
Jul 8, 2020

Conversation

jonfortescue
Copy link
Member

@jonfortescue jonfortescue commented Jul 8, 2020

I was not able to locally reproduce the Rollout Scorer not picking up issues like it has on a few scorecards (per #10188) -- both the rollout scorer console app and the Azure Function (run locally) produce the correct results. This suggests that the issue purely lies in the function when running in Azure. The best way to determine this, however, is to run the app in staging.

This PR adds a ton of AppInsights logging to the rollout scorer to help with debugging these things in prod & staging. This should make debugging much easier.

Logging added:

  • Raw AzDO queries (uris, no auth or headers)
  • Hotfix & rollback detection (from commit messages)
  • GitHub API query & number of issues returned
  • [TRACE] Logs looping over every issue noting labels for all
  • Rollout issue/hotfix/rollback/downtime detection form GitHub issues
  • Build time to rollout calculation
  • [TRACE] Start/end/approval times for builds
  • Downtime calculation
  • Failure detection -- logs last build w/ link & its result status

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only nit I have is the use of the name Utilities for logging, but that's how you already had it set up. Just seems a little weird to me. NBD, though.

LGTM shipit

@jonfortescue
Copy link
Member Author

jonfortescue commented Jul 8, 2020

While I was here, I added a case for failure detection if the last rollout is a rollback.

Actually, just going to merge this and put it in the other PR.

@jonfortescue jonfortescue merged commit dec13b3 into dotnet:master Jul 8, 2020
@jonfortescue jonfortescue deleted the MoreLogging branch July 8, 2020 23:46
meganaquinn pushed a commit to meganaquinn/arcade-services that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants