Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'runtimes' to global.json for validation testing #385

Merged
merged 1 commit into from
May 10, 2019
Merged

Add 'runtimes' to global.json for validation testing #385

merged 1 commit into from
May 10, 2019

Conversation

natemcmaster
Copy link
Contributor

No description provided.

@natemcmaster
Copy link
Contributor Author

Depends on #386

@natemcmaster
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 385 in repo dotnet/arcade-validation

@natemcmaster
Copy link
Contributor Author

cc @chcosta

I don't have write access to this repo, but I think this would have caught issues in running dotnet-install.sh (both the chmod +x issue and dotnet/arcade#2730)

@chcosta
Copy link
Member

chcosta commented May 9, 2019

I don't have write access either.

@ChadNedzlek @riarenas , do you know who can merge this change?

@riarenas
Copy link
Member

riarenas commented May 9, 2019

Everyone in @dotnet/dnceng should now have permissions.

@riarenas
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riarenas
Copy link
Member

@natemcmaster Looks like the feature is now working for Linux as well after the fixes. Thanks for adding this!

@riarenas riarenas merged commit f45bc60 into dotnet:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants