Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mariner usage #15486

Open
richlander opened this issue Feb 5, 2025 · 1 comment
Open

Remove Mariner usage #15486

richlander opened this issue Feb 5, 2025 · 1 comment

Comments

@richlander
Copy link
Member

richlander commented Feb 5, 2025

Mariner 2.0 will go EOL in June 2025. We need to remove all usage of it before that date. There are references to it in this repo and (as you know) this repo (in some cases) affects all other repos.

image: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-fpm

image: mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-fpm

<PropertyGroup Condition="'$(GenerateRpm)' == 'true'">
<CreateRPMForCblMariner>true</CreateRPMForCblMariner>
<!-- PackageTargetOS is a distro-specific version suffix, used for deps packages, including the one for CBL Mariner.
We do not want to create additional CBL Mariner named RPMs of those packages. -->
<CreateRPMForCblMariner Condition="'$(PackageTargetOS)' != ''">false</CreateRPMForCblMariner>
</PropertyGroup>
<PropertyGroup Condition="'$(CreateRPMForCblMariner)' == 'true'">
<!-- CBL-Mariner 1.0 -->
<_CblMarinerVersionSuffix>cm.1</_CblMarinerVersionSuffix>
<_InstallerBuildPartCblMariner>$(Version)-$(_CblMarinerVersionSuffix)-$(_InstallerArchSuffix)</_InstallerBuildPartCblMariner>
<_InstallerFileNameWithoutExtensionCblMariner>$(InstallerName)-$(_InstallerBuildPartCblMariner)$(CrossArchContentsBuildPart)</_InstallerFileNameWithoutExtensionCblMariner>
<_InstallerFileCblMariner>$(PackageOutputPath)$(_InstallerFileNameWithoutExtensionCblMariner)$(InstallerExtension)</_InstallerFileCblMariner>
<!-- CBL-Mariner 2.0 -->
<_CblMariner2VersionSuffix>cm.2</_CblMariner2VersionSuffix>
<_InstallerBuildPartCblMariner2>$(Version)-$(_CblMariner2VersionSuffix)-$(_InstallerArchSuffix)</_InstallerBuildPartCblMariner2>
<_InstallerFileNameWithoutExtensionCblMariner2>$(InstallerName)-$(_InstallerBuildPartCblMariner2)$(CrossArchContentsBuildPart)</_InstallerFileNameWithoutExtensionCblMariner2>
<_InstallerFileCblMariner2>$(PackageOutputPath)$(_InstallerFileNameWithoutExtensionCblMariner2)$(InstallerExtension)</_InstallerFileCblMariner2>
</PropertyGroup>
</Target>

There may be other instances. These file segments give a flavor of what needs to be remediated.

We're going to need to make these changes every couple years with Azure Linux. We should ensure that it is efficient to make these changes. It appears that there are references to Mariner 1.0. Those should have been removed ages ago.

Related: dotnet/runtime#112191

@richlander
Copy link
Member Author

richlander commented Feb 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant