IBC data XML output paths collide for some assemblies #2309

tmat · 2019-03-21T21:32:30Z

EXEC : error : the following exception was thrown while processing profile data [E:\A\_work\691\s\src\ExpressionEvaluator\Core\Source\ResultProvider\Portable\Microsoft.CodeAnalysis.ResultProvider.csproj]
  System.IO.IOException: The process cannot access the file 'E:\A\_work\691\s\artifacts\tmp\Release\ibcxml\Microsoft.CodeAnalysis.ExpressionEvaluator.ResultProvider.dll.ibc.xml' because it is being used by another process.
     at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
     at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
     at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy)
     at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync)
     at System.Xml.XmlWriterSettings.CreateWriter(String outputFileName)
     at IBCRead.DumpAsXml(String outFileName) in /_/src/IbcMerge/ibcmerge.cs:line 9535
     at IBCMerge.Merge(String[] args) in /_/src/IbcMerge/ibcmerge.cs:line 10871

The text was updated successfully, but these errors were encountered:

tmat · 2019-03-21T21:32:42Z

@jaredpar FYI

jaredpar · 2019-03-21T21:35:16Z

Do you have a build link I can look at here?

Wonder how this could happen. My assumption was this isn't an issue because it would require calling ibcmerge in parallel on the same assembly. Which itself would be a bug.

tmat · 2019-03-21T21:35:46Z

I think its a different TFM of the same project.

tmat · 2019-03-21T21:37:21Z

We are embedding the same IBC data to all flavors of the assemblies built from the same project.

tmat · 2019-03-21T21:40:08Z

A quick fix would be to use a random GUID for the XML file name.

A better fix would be to use MVID of the assembly. I think we need to group the trained assemblies by their MVIDs anyways to be completely correct.

jaredpar · 2019-03-21T21:50:46Z

MVID sounds good. Could essentially emit <assembly name>-<target framework>-<mvid>.ngen.txt. Think the target framework would help a bit in debugging on occasion.

Is there a reliable way to get the MVID without loading the DLL?

jaredpar · 2019-03-21T21:54:17Z

Perfect. Already referencing SRM. Will use that for MVID.

tmat · 2019-03-21T21:55:57Z

Yes, also you can parse TFM attribute from the assembly. We already do that in signtool. you can copy that code.

arcade/src/Microsoft.DotNet.SignTool/src/Configuration.cs

Line 394 in e30b95e

    
           private static void GetTargetFrameworkAndCopyright(string filePath, out string targetFramework, out string copyright)

tmat · 2019-03-21T21:59:06Z

<assembly name>-<target framework>-<mvid>.ngen.txt sounds good for the final output file. We can use Guid.NewGuid() for the temporary XML file. The name does not matter.

Temporary work around for #2309

markwilkie · 2019-03-22T19:05:28Z

Looks like this issue might could be closed?

jaredpar · 2019-03-22T19:14:36Z

No still work to do. There were actually two bugs here:

The double writes to same files during build. Most likely due to multi-tf builds.
The disable logging code didn't fully disable logging.

@JoeRobich fixed the second issue. This one is still tracking the first issue.

The NGEN method logging code didn't account for the fact that we run IBCMerge for the same assembly multiple times when the project uses multi-targeting. This created race conditions on both writing the temp XML file and the NGEN method list. This PR fixes this by properly writing out separate files for each target framework of an assembly. closes #2309

Updates (dotnet#2361) Update dependencies from https://github.com/dotnet/arcade build 20190327.11 (dotnet#2363) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19177.11 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19177.11 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19177.11 - Microsoft.DotNet.SignTool - 1.0.0-beta.19177.11 - Microsoft.DotNet.SwaggerGenerator.MSBuild - 1.0.0-beta.19177.11 Add missing corefx test files for mono Update JenkinsShutdownStatus.md Update JenkinsShutdownStatus.md Update JenkinsShutdownStatus.md Move images folder to correct subfolder (dotnet#2372) Added partial facade generator (dotnet#2221) * added partial facade genertor * c# coding done * making corefx projects work with new genfacades * removing nesting types from reference assembly, adding generic support nad increasing restriction of public types * Minor naming changes and other minor feedback * making nested, full facades and some dwarning disables * using ispartialfacade to use new tool * making compile errors work * Added missingtypes List * eric feedback * name changes, catch exception removed and spport for generic type parameters greater than 9 * GenFacadesOmitType added and IgnoreMissitypeList prefixed with genfacades * avoiding doube casting, omittype name change WIP Create a GH issue on publishing error(s) Try to tag non-bot accounts only Make a NuGet package instead Remove Octo using Correct passed values to .proj Correct passed values to .proj Revert changes in .proj Just create the package PR feedback Add envs for artifacts, toolset, tools, and log directories fixes dotnet#2276 use VSO vars instead remove spaces between ] and $ Update NGEN optimization doc (dotnet#2355) Add support for signing validation in the publishing release pipelines. (dotnet#2362) * Add support for signing validation in the publishing release pipelines. * Some adjustments * More comments. * PR feedback: add --traverse-subfolders Fix typos in ApiCompat project (dotnet#2293) * Fix typos in output text * Fix typos in comments Update dependencies from https://github.com/dotnet/arcade build 20190329.1 (dotnet#2380) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19179.1 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19179.1 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19179.1 - Microsoft.DotNet.SignTool - 1.0.0-beta.19179.1 - Microsoft.DotNet.SwaggerGenerator.MSBuild - 1.0.0-beta.19179.1 Update JenkinsShutdownStatus.md Fix race with AssemblyLoadContext.ResolveUsingResolvingEvent (dotnet#2360) Remove xunit.console.deps.json from output dir (dotnet#2381) 2286: Return passing result test for exit code 0 when no result files are found. Fix NGEN method logging The NGEN method logging code didn't account for the fact that we run IBCMerge for the same assembly multiple times when the project uses multi-targeting. This created race conditions on both writing the temp XML file and the NGEN method list. This PR fixes this by properly writing out separate files for each target framework of an assembly. closes dotnet#2309 Remove MVID After verifying the race locally removing the MVID. It's clear the race is about TF which is now properly covered. Keeping the MVID out of the name means that we can more easily diff NGEN between builds. Respond to PR feedback Use verbose for xunit execution By default the xunit output only includes tests which were skipped or failed. It provides no information about how tests are executed. This is fine for day to day execution but insufficient for CI jobs. When tests crash rudely then there is no context for why a test failed. For instance if there is a `StackOverflowException` or sigsegv then the log doesn't have any data indicating what test failed. The `-verbose` flag causes xunit to output detailed information about test execution including Starting and Finished notations. With this output its clear what test caused the crash as there will be a Starting notation as the last entry in the log. This can be invaluable when tracking down crashes / hangs. Particularly on Unix where we don't have dump support yet. Example output for a successfully executing test. ``` Microsoft.CodeAnalysis.CSharp.UnitTests.PreprocessorTests.TestIfFalseElifFalseElseEndif [STARTING] Microsoft.CodeAnalysis.CSharp.UnitTests.PreprocessorTests.TestIfFalseElifFalseElseEndif [FINISHED] Time: 0.0003478s ``` Update dependencies from https://github.com/dotnet/arcade build 20190329.2 (dotnet#2387) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19179.2 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19179.2 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19179.2 - Microsoft.DotNet.SignTool - 1.0.0-beta.19179.2 - Microsoft.DotNet.SwaggerGenerator.MSBuild - 1.0.0-beta.19179.2 Update JenkinsShutdownStatus.md Update JenkinsShutdownStatus.md Add angular language to swagger generator (dotnet#2378) Fix docs URL reference Fix docs URL reference add append line in sourcegenerator to comment that the following is autogenerated Add xunit.console.deps.json only for netcoreapp (dotnet#2388) Make project packable Add Microsoft.DotNet.RemoteExecutor (dotnet#2176) * Add Microsoft.DotNet.RemoteExecutor Update dependencies from https://github.com/dotnet/arcade build 20190401.12 (dotnet#2400) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19201.12 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19201.12 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19201.12 - Microsoft.DotNet.SignTool - 1.0.0-beta.19201.12 - Microsoft.DotNet.SwaggerGenerator.MSBuild - 1.0.0-beta.19201.12 Remove deps from test archive (dotnet#2399) Update JenkinsShutdownStatus.md Fix a typo in StartHere.md (dotnet#2325) Fix exit codes (dotnet#2394) It used to be that a return code of 2 was success (indicating the client was disconnected). Now, 0 appears to be the correct return code. Addressing issues with the new GenfacadesSourceTask (dotnet#2404) * moving using task to main file for shims, adding license header, exposing assembly path * handing platformNotSupportedGeneratedCode * Running GenerateNotSupportedSource as first target of coreCompileDependsOn, hence removing the dependency of genfacades Use reference Id for enum names if it exists. (dotnet#2405) Start consuming the latest portable IBCMerge (dotnet#2365) Update dependencies from https://github.com/dotnet/arcade build 20190402.13 (dotnet#2410) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19202.13 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19202.13 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19202.13 - Microsoft.DotNet.SignTool - 1.0.0-beta.19202.13 - Microsoft.DotNet.SwaggerGenerator.MSBuild - 1.0.0-beta.19202.13 missing property Tag (dotnet#2414) [Pool Provider] Prod, more logging, and correlation script (dotnet#2409) * Fix exit codes It used to be that a return code of 2 was success (indicating the client was disconnected). Now, 0 appears to be the correct return code. * [Pool Provider] Prod, more logging, and correlation script - Add a prod deployment (which is really ahead of int at this point). - Add a additional logging in based on the Maestro logging setup - Add a rough script that can map from a build onto the helix work items (and other info) that was submitted for that build Move TheoryData helper to XUnitExtensions (dotnet#2403) * Move TheoryData helper to XUnitExtensions * Move tests over to XUnitExtensions Add support for junit results (dotnet#2421) * Add support for junit results This changes adds support to the helix sdk azure pipelines reporter to process junit xml results from junit-results.xml files. * skip_reason can't be none * Use if instead of or because of FutureWarning * Add validation of expected failures * Use correct property name * Make expected failed tests correct. Update dependencies from https://github.com/dotnet/arcade build 20190403.10 (dotnet#2425) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19203.10 - Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19203.10 - Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19203.10 - Microsoft.DotNet.SignTool - 1.0.0-beta.19203.10 - Microsoft.DotNet.SwaggerGenerator.MSBuild - 1.0.0-beta.19203.10 Update AsyncPublishing_HowToUse.md (dotnet#2424) Adding other repo feeds Publish symbols using release pipelines (dotnet#2407) * Adding PublishToSymbolServers Fix itemgroup adding Fix filename Fix bad merge Fix bad merge remove verbose

JoeRobich mentioned this issue Mar 21, 2019

Disable EnableNgenOptimizationLogDetails dotnet/roslyn#34339

Merged

jaredpar added a commit that referenced this issue Mar 21, 2019

Temporary work around for bad write

7ebfb03

Temporary work around for #2309

jaredpar mentioned this issue Mar 21, 2019

Temporary work around for bad write #2312

Closed

tmat assigned jaredpar Mar 21, 2019

JoeRobich mentioned this issue Mar 22, 2019

Re-enable EnableNgenOptimizationLogDetails dotnet/roslyn#34356

Closed

jaredpar mentioned this issue Mar 26, 2019

Fix NGEN method logging #2344

Merged

jaredpar closed this as completed in #2344 Mar 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IBC data XML output paths collide for some assemblies #2309

IBC data XML output paths collide for some assemblies #2309

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

jaredpar commented Mar 21, 2019

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

jaredpar commented Mar 21, 2019

jaredpar commented Mar 21, 2019

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

markwilkie commented Mar 22, 2019

jaredpar commented Mar 22, 2019

IBC data XML output paths collide for some assemblies #2309

IBC data XML output paths collide for some assemblies #2309

Comments

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

jaredpar commented Mar 21, 2019

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

jaredpar commented Mar 21, 2019

jaredpar commented Mar 21, 2019

tmat commented Mar 21, 2019

tmat commented Mar 21, 2019

markwilkie commented Mar 22, 2019

jaredpar commented Mar 22, 2019