-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use something (anything but bash) for bash json parsing #2510
Comments
We could probably use python for json parsing we need. All helix machines are guaranteed to have it because helix requires it, and most linuxes have it. I don't think the same is true of jq. |
The fact that it is on helix machines is irrelevant. We would need to make this work for all OSS contributors on all platforms that CoreCLR supports and actually more. I don't think reading a version from a text file warrants making it more difficult to port CoreCLR on a new platform. |
Porting coreclr to a new platform will require python, because all the builds run through helix. Even worse really, the azure devops agent is written in C# and runs on .NET Core, so a new platform would require a complex bootstrapping thing or cross-compilation. Every linux operating system we have brought up for helix has had python. They didn't all agree on the version, but JSON parsing is easy to do in a version tolerant way. I haven't seen |
Well, yes, eventually it will. But not when you're starting and want just to run build locally. I'm fine with Python if we have solid data on its availability without installation on all Linux distros we support. I'd still prefer not to have the dependency at all though. |
Moving out beyond P7 |
We have places in Arcade where we have to parse Json before an sdk is acquired. Powershell makes this easy on Windows. On Bash, the parsing is fragile and error prone. We should consider adopting a dependency on a more robust parsing tool in Arcade.
Something like jq
From chcosta@737e293#r33161980
The text was updated successfully, but these errors were encountered: