Allow users to supply a custom SDK and source-built artifacts #100
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
build.sh
Outdated
| cp -a "${CUSTOM_SDK_DIR}" $__scriptpath/.dotnet | ||
| sdk_version="$(basename "$(find "${CUSTOM_SDK_DIR}/sdk" -maxdepth 1 -type d -printf "%p\n" | sort -rn | head -1)")" | ||
| echo "Found SDK version $sdk_version in ${CUSTOM_SDK_DIR}" | ||
| jq ".tools.dotnet = \"$sdk_version\"" global.json > global.json.tmp && mv global.json.tmp global.json |
There was a problem hiding this comment.
I don't think the CI images that we use have jq installed on them. Can you use sed here?
There was a problem hiding this comment.
I will give it a shot. But it wont be as reliable or robust as parsing json using something that understands json. Is a scripting language like perl or python available in the CI images?
There was a problem hiding this comment.
Arcade uses grep: https://github.com/dotnet/arcade/blob/3dec733f38264d7068ae75b3bb85e4c43979bcc7/eng/common/tools.sh#L76-L90
There's some discussion about changing to something else that actually understands json at dotnet/arcade#2510, but in core infra that we want to work when bringing up new platforms, depending on stuff we may not need to is a very hard sell.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This change tries to implement something analogous to dotnet/source-build#1455 for source-build-reference-packages. With this change, I can build source-build-reference-packages completely offline on linux-x64 against a source-built SDK by running: ./build.sh --with-sdk /usr/lib64/dotnet \ --with-packages /usr/lib64/dotnet/source-built-artifacts/*.tar.gz
omajid
force-pushed
the
provide-local-bits
branch
from
14ce71b to
93e4ef4
Compare
|
@omajid ready to merge? |
|
@dseefeld Yes, looks good on my end. |
This change tries to implement something analogous to dotnet/source-build#1455 for source-build-reference-packages.
With this change, I can build source-build-reference-packages completely offline on linux-x64 against a source-built SDK by running:
This adds a dependency on thejqtool for editing json.