-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdl tasks failing with .NET 5 #5168
Comments
@markwilkie it seems Policheck needs a 2.x SDK installed. I would suggest that we lift this requirement and do either one of these:
|
Any insight @sunandabalu ? |
cc @davidknise |
Hey guys, I don't believe PoliCheck has the requirement, but Guardian. The "Run Codesign Validation" step is running the "Use .NET Core" code to resolve to version 2.2.402. You could add that build step before running Guardian to resolve this. We also offer a standalone windows package, so you could update the install step instead: We are working on updating Guardian and the additional toolset to 3.1.201 and will be installing both 2.2.402 and 3.1.201 on our Guardian build tasks for a period of time. |
@davidknise what are your thoughts on updating Gaurdian's runtimeconfig.json to permit roll-forward in case the target runtime is not present? .NETCore 2.2 isn't an LTS release and is currently out of support: https://dotnet.microsoft.com/platform/support/policy/dotnet-core |
@ericstj "We are working on updating Guardian and the additional toolset to 3.1.201 and will be installing both 2.2.402 and 3.1.201 on our Guardian build tasks for a period of time." Permit roll-foward would be great, and I didn't know that was an option. Guardian doesn't have or emit that file. Since we're in the dotnet org here on GitHub, do you happen to know what the associated MSBuild property is for this? |
Using the 3.0 SDK you can use @vitek-karas also shared lots of good pointers here: dotnet/docs#12237 (comment) |
I am trying to enable the policheck for runtime repo. In the runtime repo, we use global.json file to download the latest sdk and use this.
But it seems like policheck is not compatible with the lastest sdk and require 2.2 sdk.
Build ID: https://dev.azure.com/dnceng/internal/_build/results?buildId=579800
This issue is blocking effort for enabling policheck for the runtime repo
cc @sunandabalu @ericstj
The text was updated successfully, but these errors were encountered: