Enable Policheck

[Anipik]

I have scheduled an official build to test the change as well

[safern]

LGTM as long as the official build is green.

[dagood]

I have scheduled an official build to test the change as well

I highly recommend linking to it from this PR to make it easy to look at the results.

[stephentoub]

@Anipik, should this be merged?

[safern]

I think this should be addressed first: #33841 (comment)

It is really helpful for the comment to link to the variable group.

[Anipik]

It is really helpful for the comment to link to the variable group.

i moved it to here. https://github.com/dotnet/runtime/pull/33841/files#diff-2601d29fabf2d8fa57d58b3eb4ff8d17R28 The variable group is still not recognised , can you suggest the appropriate place ?

@Anipik, should this be merged?

This post build stage is still not getting passed on the actual build https://dev.azure.com/dnceng/internal/_build/results?buildId=579800

i am working with the arcade folks to get it fixed.

[safern]

i moved it to here. https://github.com/dotnet/runtime/pull/33841/files#diff-2601d29fabf2d8fa57d58b3eb4ff8d17R28

Right, but this won't work because the post-build.yml template doesn't take any variables parameters, and it doesn't flow it to the underlying templates, so it is just getting lost when expanding that template.

The variable group is still not recognised , can you suggest the appropriate place ?

You need to add it to this section which is where we declare the yml variables:
https://github.com/dotnet/runtime/blob/master/eng/pipelines/runtime-official.yml#L23

Once you put it there it should work. Since it will be in a different template, add the comment back referencing the variable group. Also, since runtime-official.yml is only used in official builds and not used in PRs or dnceng/public you shouldn't need to add the condition to check that we're in internal.

[ViktorHofer]

@Anipik we want to port this into preview3 as just discussed in Tactics.

[Anipik]

linking the issues
dotnet/arcade#5149
dotnet/arcade#5168

[jaredpar]

Doing this in official builds seems like the wrong approach. We should be catching this at PR time.

[safern]

This should be done in arcade instead, this is part of eng/common/*.

[Anipik]

Yes they will be taking in the change as well, if the solution solves the problems

[jaredpar]

Removing the reject for now as this is apparently the intended path forward. Going to be following up separately on removing this from official builds as this will seemingly reduce official build reliability. Want us to persue other alternatives here, rolling builds, separate pipelines in the internal project or ideally PR validation.

Cause

[ViktorHofer]

@Anipik what's the status on this?

[safern]

@Anipik it seems like we no longer need this given @jcagme's email from yesterday? Instead we need to add the sdl config file on .eng?