Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arcade 6 forces consumers to use Microsoft.NETFramework.ReferenceAssemblies 1.0.0 #7053

Closed
jmarolf opened this issue Mar 5, 2021 · 2 comments
Closed

Arcade 6 forces consumers to use Microsoft.NETFramework.ReferenceAssemblies 1.0.0 #7053

jmarolf opened this issue Mar 5, 2021 · 2 comments

Comments

@jmarolf
Copy link
Contributor

jmarolf commented Mar 5, 2021

Even though the version of reference assemblies is set here it is not respected and all arcade repos on version 6 build with <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0">

Roslyn will need to work around this in custom targets. If it is intentional that customers build against version 1.0.0 then the property in DefaultVersions.props should be modified or deleted.
@jaredpar
Copy link
Member

jaredpar commented Mar 5, 2021

Can you elaborate on what problem that causes for Roslyn when we can't move to a different version?

jmarolf added a commit to jmarolf/roslyn that referenced this issue Mar 5, 2021
@jmarolf
Work around dotnet/arcade#7053
9780646
@jmarolf jmarolf mentioned this issue Mar 6, 2021
Closed
@garath
Copy link
Member

garath commented Mar 11, 2021

Curious about the answer to Jared's question. If there's something more blocking, please reopen.

@garath garath closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaredpar @garath @jmarolf