Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for required keyword #10021

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Add support for required keyword #10021

merged 5 commits into from
Jul 15, 2022

Commits on Jul 14, 2022

  1. Add support for required keyword to GenAPI 

    Also avoid emitting the new `CompilerFeatureRequiredAttribute`
    @ericstj
    ericstj committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    a818094 View commit details
    Browse the repository at this point in the history

  2. Support LangVersion in Roslyn-based GenFacades tasks

    @ericstj
    ericstj committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    9467cd4 View commit details
    Browse the repository at this point in the history

  3. Don't redistribute roslyn in GenFacades 

    Use the one that the project is compiling with.  This is a copy of the logic from
https://github.com/dotnet/sdk/blob/d670c1d9c72190cdf8228ed000847f9bde55ce71/src/Compatibility/Microsoft.DotNet.Compatibility/ValidatePackage.cs#L47
    @ericstj
    ericstj committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    f163617 View commit details
    Browse the repository at this point in the history

  4. Exclude the compiler generated Obsolete attribute from types using `r… 

    …equired`
    @ericstj
    ericstj committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    8052e5b View commit details
    Browse the repository at this point in the history

  5. Address feedback

    @ericstj
    ericstj committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    3858541 View commit details
    Browse the repository at this point in the history