Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty project collection inside Project.FromFile() #10318

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Aug 5, 2022

To double check:

Testing ongoing; my first attempt used a Warning() call and I'm having trouble treating warnings as warnings in the ASP build
When this publishes I can try it: https://dnceng.visualstudio.com/internal/_build/results?buildId=1926170&view=results

@MattGal MattGal changed the title Use LoadProject instead of FromFile() Use empty project collection inside Project.FromFile() Aug 5, 2022
@riarenas riarenas requested a review from rainersigwald August 5, 2022 18:34
@MattGal
Copy link
Member Author

MattGal commented Aug 5, 2022

Tested by @lbussell , (I had some challenges with local sourcebuild setup), I believe this fixes the issue seen in some source build scenarios.

@MattGal MattGal requested a review from lbussell August 5, 2022 21:33
Copy link
Contributor

@lbussell lbussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran darc-update with these changes and then ran the source-build repo leg locally and it appeared to build cleanly.

@MattGal MattGal enabled auto-merge (squash) August 5, 2022 21:34
@MattGal MattGal merged commit 58aed6c into main Aug 5, 2022
@akoeplinger akoeplinger deleted the load-project-differently branch November 22, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants