Fix versioning errors in workloads #10363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
previously approved these changes
Aug 10, 2022
pjcollins
previously approved these changes
Aug 10, 2022
|
@dsplaisted, @pjcollins need you to re-approve because of an AzDo fix I had to take and that reset your votes. @MattGal, can you help merge in case MattM can't? |
MattGal
approved these changes
Aug 11, 2022
joeloff
added a commit
to joeloff/arcade
that referenced
this pull request
Aug 12, 2022
* Fix versioning errors in workloads * Disable TRX tests while reporting to AZDO is broken (dotnet#10358) (dotnet#10380) Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>
mmitche
pushed a commit
that referenced
this pull request
Aug 15, 2022
* Refactoring workload build tasks (#8645) * Refactoring workload build tasks * Fix source build and some random cleanup * Updating tests, code cleanup * Minor fixes, unit test conversion * Mark tests as Windows only, fix missing content for Helix * Hide WiX and test packages from Solution Explorer * Fix duplicate publish items * Fix link target for helix * Fix link metadata for WiX * Pass ICE suppressions to Light, more cleanup * Fix file extraction for packs, add unit test for template pack MSI * Pass ICE suppressions to Light (#9061) * Create workload pack group installers (#9514) * Remove duplicate PackageReference * Create MSIs for workoad pack groups * Build NuGet wrapper packages for workload pack group MSIs * Generate WorkloadPackGroups.json in manifest MSIs * Add swix authoring for workload pack groups * De-duplicate workload pack group creation * Put braces around ProductCode and UpgradeCode registry values * Write registry keys for pack groups * Fix swix dependencies for pack groups * Use correct GUID format when setting candle variables * Add test for creating pack group dependency in SWR file * Support building with missing workload packs (#9628) * Support building with missing workload packs * Include extracted manifest files in manifest MSI payload nupkg * Fix versioning errors in workloads (#10363) * Fix versioning errors in workloads * Disable TRX tests while reporting to AZDO is broken (#10358) (#10380) Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com> * clean up, api changes Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com> Co-authored-by: Matt Galbraith <MattGal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address multiple versioning issues
stringand notVersionand a package definition like