-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Xunit to 2.4.2 #10512
Update Xunit to 2.4.2 #10512
Conversation
/azp run arcade-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@dotnet/dnceng can you please help with diagnosing the test failures? I spent some time looking at the binlogs to see if the work items are submitted incorrectly but as the XUnitWorkItems feature is something very unfamiliar to me, I don't have any clues. All work items fail with the following error:
|
Looking at the logs, I think it's failing on trying to get |
Yes, it was just recently published to nuget.org (two weeks ago). Can you please add the package to the dotnet-eng feed? |
We usually add packages like this to the dotnet-public feed. I just checked and it's already there. Is it possible to fetch it from there? |
If the 2.4.2 prerelease versions were pushed to dotnet-eng, then we should also push the stable version here. Otherwise people might not be able to resolve the 2.4.2 stable version that arcade propagates. For the future we can for sure avoid having these in dotnet-eng. |
I added 2.4.2 to dotnet-eng, should be unblocked now |
/azp run arcade-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should fix the typo before merging.
No description provided.