Skip to content

Introduce targets to filter target frameworks #12310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jan 24, 2023

Relies on dotnet/msbuild#8350 to be active or not cause build errors when not enabled. This is largely still experimental and may change. Enables the ability for an invocation of an arcade build to only build a desired set of target frameworks. The primary consumer is source-build. This allows source-build to simply remove TFMs from the build that would require SBRPs without extensive changes in project files.

To double check:

Relies on dotnet/msbuild#8350 to be active or not cause build errors when not enabled. This is largely still experimental and may change.
Enables the ability for an invocation of an arcade build to only build a desired set of target frameworks. The primary consumer is source-build. This allows source-build to simply remove TFMs from the build that would require SBRPs without extensive changes in project files.
@mmitche mmitche force-pushed the target-framework-filtering branch from d255b32 to 1c654fd Compare January 24, 2023 20:54
@mmitche mmitche requested a review from a team January 24, 2023 21:20
@mmitche mmitche enabled auto-merge (squash) January 25, 2023 18:11
@mmitche mmitche requested a review from a team January 26, 2023 20:15
@tkapin
Copy link
Member

tkapin commented Jan 30, 2023

@mmitche Can you advise on a setup to simulate and check this locally (e.g., repos to test with, etc.)? Cheers

@MichaelSimons
Copy link
Member

To roll this out in source-build, is the idea we would enable this on a per repo basis starting at installer and then once all repos are onboarded we would enable it by default at the source-build level and remove the per repo settings?

@mmitche
Copy link
Member Author

mmitche commented Jan 30, 2023

@mmitche Can you advise on a setup to simulate and check this locally (e.g., repos to test with, etc.)? Cheers

I only had a hacked up setup in source-build that was half working. This is now in the SDK, so I'm working on getting it into arcade for testing in non-SB setups.

@mmitche mmitche force-pushed the target-framework-filtering branch from c74aad8 to 2bdc362 Compare January 30, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants