Skip to content

Allow PublicSign=true even if full keys are available #12749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmitche merged 2 commits into from
Mar 6, 2023
Merged

Allow PublicSign=true even if full keys are available #12749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d4af4a
Allow PublicSign=true even if full keys are available
omajid Mar 1, 2023
ed22cce
Fix typo in src/Microsoft.DotNet.Arcade.Sdk/tools/StrongName.targets
omajid Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Microsoft.DotNet.Arcade.Sdk/tools/StrongName.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
<!--
Reads variables:
SignAssembly "true" to sign the output assembly of the current project
FullAssemblySigningSupported "false" to use public signing even when full signing is possible. This is useful
in environments where full signing is non-functional or not desired. For example,
in some Linux distributions RSA+SHA1 (required for full signing) is not
functional/available, and trying to use full signing results in the runtime
throwing an exception. For more details and an example, see
https://github.com/dotnet/runtime/issues/65874.
StrongNameKeyId The id of the key used for strong name generation

Writes variables:
Expand Down Expand Up @@ -42,7 +48,7 @@
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)snk/AspNetCore.snk</AssemblyOriginatorKeyFile>
<PublicKey>$(MicrosoftAspNetCorePublicKey)</PublicKey>
<PublicKeyToken>adb9793829ddae60</PublicKeyToken>
<PublicSign>false</PublicSign> <!-- The MicrosoftAspNetCore strong name key is a full key -->
<PublicSign Condition="'$(FullAssemblySigningSupported)' != 'false'">false</PublicSign> <!-- The MicrosoftAspNetCore strong name key is a full key -->
</PropertyGroup>
</When>
<When Condition="'$(StrongNameKeyId)' == 'ECMA'">
Expand All @@ -63,7 +69,7 @@
<PublicKey>$(OpenPublicKey)</PublicKey>
<PublicKeyToken>cc7b13ffcd2ddd51</PublicKeyToken>
<DelaySign>false</DelaySign>
<PublicSign>false</PublicSign> <!-- The Open strong name key is a full key -->
<PublicSign Condition="'$(FullAssemblySigningSupported)' != 'false'">false</PublicSign> <!-- The Open strong name key is a full key -->
</PropertyGroup>
</When>
<When Condition="'$(StrongNameKeyId)' == 'SilverlightPlatform'">
Expand Down