-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at prebuilt-detection #13027
Conversation
- Add a few exclusions that will need SBRPs - Add dependencies on SBRP and SBE, with subscriptions - Added dependency on SDK and deployment tools. No subscription added for this.
@MichaelSimons Same process as with sdk. There are a few prebuilts left here in this PR. They're ancient, and I'd like to see whether they are upgradeable first. |
FYI, @mthalman is adding the SBRPs in dotnet/source-build-reference-packages#595 least the ones he encountered when enabling the repo pvp feature. |
@mthalman Hold off on System.IO.Packaging 4.5.0. I think that one may be upgradeable. |
I'll be adding more packages to my PR that I missed: dotnet/source-build-reference-packages#595 (comment). @mmitche - After applying your changes with my PVP flow changes, we're in alignment with the prebuilts that are showing up. |
Thanks @MichaelSimons. I have eliminated a few more and am hunting down the last few where I think upgrades can be made. |
@MichaelSimons I think this may be clean now. |
@joeloff Any concern over the manfiest reader upgrade here? https://github.com/dotnet/arcade/pull/13027/files#diff-1ea18ff65faa2ae6fed570b83747086d0317f5e4bc325064f6c14319a9c4ff67R91 |
Should be fine. We only use that to process workload manifests from the Arcade build tasks in other repos (emsdk/runtime). |
Fixes: #10721 |
To double check: