Add a trailing slash to $env:VSINSTALLDIR #13406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
reviewed
May 3, 2023
eng/common/tools.ps1
Outdated
| @@ -399,7 +399,8 @@ function InitializeVisualStudioMSBuild([bool]$install, [object]$vsRequirements = | |||
| # Locate Visual Studio installation or download x-copy msbuild. | |||
| $vsInfo = LocateVisualStudio $vsRequirements | |||
| if ($vsInfo -ne $null) { | |||
| $vsInstallDir = $vsInfo.installationPath | |||
| # Ensure vsInstallDir has a trailing slash | |||
| $vsInstallDir = Join-path $vsInfo.installationPath "\" | |||
There was a problem hiding this comment.
Does Join-Path take care of the duplicate trailing slash?
[nit]
Suggested change
| $vsInstallDir = Join-path $vsInfo.installationPath "\" | |
| $vsInstallDir = Join-Path $vsInfo.installationPath "\" |
There was a problem hiding this comment.
Without a trailing slash publishing NativeAOT projects no longer works. See dotnet/runtime#85737
eerhardt
added a commit
to eerhardt/aspnetcore
that referenced
this pull request
May 3, 2023
wtgodbe
approved these changes
May 3, 2023
eerhardt
added a commit
to dotnet/aspnetcore
that referenced
this pull request
May 4, 2023
* Add infrastructure for trimming and NativeAOT test apps. This infrastructure was taken from https://github.com/dotnet/runtime/tree/c62f69be1405a8e41b56ffc05f22d791bf4c7d2d/eng/testing/linker and modified to work in dotnet/aspnetcore. Added the first test: - Generic host + value type container builder (verify that error is thrown) Contributes to #45860 * Skip IsPublishedAppTestProject projects when SkipTestBuild=true. Use `Sdk="Microsoft.NET.Sdk"` in order to skip the build correctly. Only run the AOT tests during Test. Skip "Build" and skip publishing for Helix. Ensure the IsPublishedAppTestProject projects aren't built until the shared fx is built using RequiresDelayedBuild. * Add workaround for dotnet/arcade#13406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a trailing slash publishing NativeAOT projects no longer works.
See dotnet/runtime#85737
cc @wtgodbe @missymessa @riarenas @agocke