Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignTool error logs: Display list of packages that a file is contained in #1385

Merged
merged 6 commits into from
Nov 26, 2018

Conversation

JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Nov 22, 2018

Closes: #1272

Goal: when printing error messages also print all the packages that a file appears in so that the user can easily locate in which package(s) the file was found.

Changes:

  • SignToolTests.cs: patched tests output to include the relative path of the files.
  • Configuration.cs:
    • keep track of the packages that each file appears in;
    • keep tracks of which files produced an specific error.
    • print errors at the end.

These changes were tested here: https://dnceng.visualstudio.com/internal/_build/results?buildId=47746&view=logs where you can also see the format of the output.

@JohnTortugo JohnTortugo self-assigned this Nov 22, 2018
@JohnTortugo JohnTortugo changed the title File containers path SignTool error logs: Display list of packages that a file is contained in Nov 22, 2018
@JohnTortugo
Copy link
Contributor Author

Please see on this link how the output will look like: https://dnceng.visualstudio.com/internal/_build/results?buildId=47746&view=logs

Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! This will help a lot in diagnosing signing misconfiguration.

I made one suggestion, but otherwise this looks good to me.

@JohnTortugo JohnTortugo merged commit 05587e0 into master Nov 26, 2018
@JohnTortugo JohnTortugo deleted the FileContainersPath branch November 26, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants